Replace some data-bind="click: function(){} with object functions to prevent eval()

dev/Model/Attachment.js

@@ -51,6 +51,11 @@ export class AttachmentModel extends AbstractModel {
 		return attachment;
 	}
 
+	toggleChecked(self, event) {
+		event.stopPropagation();
+		self.checked(!self.checked());
+	}
+
 	friendlySize() {
 		return FileInfo.friendlySize(this.estimatedSize) + (this.isLinked() ? ' 🔗' : '');
 	}

dev/Settings/User/Folders.js

@@ -151,6 +151,10 @@ export class UserSettingsFolders /*extends AbstractViewSettings*/ {
 		}
 	}
 
+	hideError() {
+		this.folderListError('');
+	}
+
 	toggleFolderKolabType(folder, event) {
 		let type = event.target.value;
 		// TODO: append '.default' ?

dev/Settings/User/Themes.js

@@ -60,6 +60,10 @@ export class UserSettingsThemes /*extends AbstractViewSettings*/ {
 		});
 	}
 
+	setTheme(theme) {
+		ThemeStore.theme(theme.name);
+	}
+
 	onBuild() {
 		const currentTheme = ThemeStore.theme();
 

dev/View/Admin/Login.js

@@ -33,6 +33,10 @@ export class AdminLoginView extends AbstractViewLogin {
 		});
 	}
 
+	hideError() {
+		this.submitError('');
+	}
+
 	submitCommand(self, event) {
 		let form = event.target.form,
 			data = new FormData(form),

dev/View/Popup/Account.js

@@ -22,6 +22,10 @@ export class AccountPopupView extends AbstractViewPopup {
 		});
 	}
 
+	hideError() {
+		this.submitError('');
+	}
+
 	submitForm(form) {
 		if (!this.submitRequest() && form.reportValidity()) {
 			const data = new FormData(form);

dev/View/Popup/OpenPgpGenerate.js

@@ -93,6 +93,10 @@ export class OpenPgpGeneratePopupView extends AbstractViewPopup {
 		});
 	}
 
+	hideError() {
+		this.submitError('');
+	}
+
 	showError(e) {
 		console.log(e);
 		if (e?.message) {

dev/View/Popup/Plugin.js

@@ -35,6 +35,10 @@ export class PluginPopupView extends AbstractViewPopup {
 		});
 	}
 
+	hideError() {
+		this.saveError('');
+	}
+
 	saveCommand() {
 		const oConfig = {
 			Id: this.id(),

dev/View/User/Login.js

@@ -88,6 +88,14 @@ export class LoginUserView extends AbstractViewLogin {
 		});
 	}
 
+	hideError() {
+		this.submitError('');
+	}
+
+	toggleSignMe() {
+		this.signMe(!this.signMe());
+	}
+
 	submitCommand(self, event) {
 		const email = this.email().trim();
 		this.email(email);

dev/View/User/MailBox/MessageView.js

@@ -225,6 +225,10 @@ export class MailMessageView extends AbstractViewRight {
 		});
 	}
 
+	toggleFullInfo() {
+		this.showFullInfo(!this.showFullInfo());
+	}
+
 	closeMessage() {
 		currentMessage(null);
 	}
@@ -393,9 +397,7 @@ export class MailMessageView extends AbstractViewRight {
 
 		// message information
 		registerShortcut('i', 'meta', [Scope.MessageList, Scope.MessageView], () => {
-			if (currentMessage()) {
-				this.showFullInfo(!this.showFullInfo());
-			}
+			currentMessage() && this.toggleFullInfo();
 			return false;
 		});