Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-09-07 16:37:02 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Speedup message bodies cache cleanup

Browse source 
Remove ko.bindingHandlers.link
This commit is contained in:
djmaze 2021-02-10 16:50:58 +01:00
parent 15631427b0
commit 111455054e
3 changed files with 13 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

4
dev/External/User/ko.js vendored
View file

@ -217,10 +217,6 @@ ko.bindingHandlers.sortableItem = {
} }
}; };
ko.bindingHandlers.link = {
update: (element, fValueAccessor) => element.href = ko.unwrap(fValueAccessor())
};
ko.bindingHandlers.initDom = { ko.bindingHandlers.initDom = {
init: (element, fValueAccessor) => fValueAccessor()(element) init: (element, fValueAccessor) => fValueAccessor()(element)
}; };

30
dev/Stores/User/Message.js
View file

@ -49,8 +49,6 @@ const
.replace(email, '$1<a href="mailto:$2">$2</a>'), .replace(email, '$1<a href="mailto:$2">$2</a>'),
isChecked = item => item.checked(); isChecked = item => item.checked();
let iMessageBodyCacheCount = 0;
doc.body.append(hcont); doc.body.append(hcont);
class MessageUserStore { class MessageUserStore {
@ -89,6 +87,7 @@ class MessageUserStore {
messageFullScreenMode: false, messageFullScreenMode: false,
// Cache mail bodies
messagesBodiesDom: null, messagesBodiesDom: null,
messageActiveDom: null messageActiveDom: null
}); });
@ -234,21 +233,11 @@ class MessageUserStore {
} }
purgeMessageBodyCache() { purgeMessageBodyCache() {
const end = iMessageBodyCacheCount - 15; const messagesDom = this.messagesBodiesDom(),
if (0 < end) { children = messagesDom && messagesDom.children;
let count = 0; if (children) {
const messagesDom = this.messagesBodiesDom(); while (15 < children.length) {
if (messagesDom) { children[0].remove();
messagesDom.querySelectorAll('.rl-cache-class').forEach(node => {
if (end > node.rlCacheCount) {
node.classList.add('rl-cache-purge');
++count;
}
});
if (0 < count) {
setTimeout(() => messagesDom.querySelectorAll('.rl-cache-purge').forEach(node => node.remove()), 350);
}
} }
} }
} }
@ -286,7 +275,7 @@ class MessageUserStore {
hideMessageBodies() { hideMessageBodies() {
const messagesDom = this.messagesBodiesDom(); const messagesDom = this.messagesBodiesDom();
messagesDom && messagesDom.querySelectorAll('.b-text-part').forEach(el => el.hidden = true); messagesDom && Array.from(messagesDom.children).forEach(el => el.hidden = true);
} }
/** /**
@ -506,9 +495,9 @@ class MessageUserStore {
const textBody = doc.getElementById(id); const textBody = doc.getElementById(id);
if (textBody) { if (textBody) {
textBody.rlCacheCount = ++iMessageBodyCacheCount;
message.body = textBody; message.body = textBody;
message.fetchDataFromDom(); message.fetchDataFromDom();
messagesDom.append(textBody);
} else { } else {
let isHtml = false; let isHtml = false;
if (json.Html) { if (json.Html) {
@ -549,11 +538,10 @@ class MessageUserStore {
resultHtml = '<pre>' + resultHtml + '</pre>'; resultHtml = '<pre>' + resultHtml + '</pre>';
} }
body = Element.fromHTML('<div id="' + id + '" hidden="" class="rl-cache-class b-text-part ' body = Element.fromHTML('<div id="' + id + '" hidden="" class="b-text-part '
+ (isHtml ? 'html' : 'plain') + '">' + (isHtml ? 'html' : 'plain') + '">'
+ findEmailAndLinks(resultHtml) + findEmailAndLinks(resultHtml)
+ '</div>'); + '</div>');
body.rlCacheCount = ++iMessageBodyCacheCount;
// Drop Microsoft Office style properties // Drop Microsoft Office style properties
const rgbRE = /rgb\((\d+),\s*(\d+),\s*(\d+)\)/g, const rgbRE = /rgb\((\d+),\s*(\d+),\s*(\d+)\)/g,

8
snappymail/v/0.0.0/app/templates/Views/User/MailMessageView.html
View file

@ -135,7 +135,7 @@
</a> </a>
</li> </li>
<li class="e-item" role="presentation" data-bind="visible: message() && message().hasUnsubsribeLinks()"> <li class="e-item" role="presentation" data-bind="visible: message() && message().hasUnsubsribeLinks()">
<a target="_blank" class="e-link menuitem" href="#" tabindex="-1" data-bind="link: viewUnsubscribeLink()"> <a target="_blank" class="e-link menuitem" href="#" tabindex="-1" data-bind="attr: { href: viewUnsubscribeLink }">
<i class="fontastic">✖</i> <i class="fontastic">✖</i>
<span class="i18n" data-i18n="MESSAGE/BUTTON_UNSUBSCRIBE"></span> <span class="i18n" data-i18n="MESSAGE/BUTTON_UNSUBSCRIBE"></span>
</a> </a>
@ -155,13 +155,13 @@
</a> </a>
</li> </li>
<li class="e-item dividerbar" role="presentation"> <li class="e-item dividerbar" role="presentation">
<a target="_blank" class="e-link menuitem" href="#" tabindex="-1" data-bind="link: viewViewLink()"> <a target="_blank" class="e-link menuitem" href="#" tabindex="-1" data-bind="attr: { href: viewViewLink }">
<i class="icon-file-code"></i> <i class="icon-file-code"></i>
<span class="i18n" data-i18n="MESSAGE/MENU_VIEW_ORIGINAL"></span> <span class="i18n" data-i18n="MESSAGE/MENU_VIEW_ORIGINAL"></span>
</a> </a>
</li> </li>
<li class="e-item" role="presentation"> <li class="e-item" role="presentation">
<a target="_blank" class="e-link menuitem" href="#" tabindex="-1" data-bind="link: viewDownloadLink()"> <a target="_blank" class="e-link menuitem" href="#" tabindex="-1" data-bind="attr: { href: viewDownloadLink }">
<i class="icon-download"></i> <i class="icon-download"></i>
<span class="i18n" data-i18n="MESSAGE/MENU_DOWNLOAD_ORIGINAL"></span> <span class="i18n" data-i18n="MESSAGE/MENU_DOWNLOAD_ORIGINAL"></span>
</a> </a>
@ -360,7 +360,7 @@
</div> </div>
</div> </div>
<div class="bodyText g-ui-min-height-300 rl-mv-root" <div class="bodyText g-ui-min-height-300"
data-bind="initDom: messagesBodiesDom"></div> data-bind="initDom: messagesBodiesDom"></div>
</div> </div>
</div> </div>