From 169dbfeccacb7adbec388a3bbac6f43d78274c5e Mon Sep 17 00:00:00 2001
From: the-djmaze <>
Date: Fri, 25 Feb 2022 12:11:32 +0100
Subject: [PATCH] Added some documentation

---
 dev/Knoin/AbstractViews.js | 12 ++++++++----
 dev/Knoin/Knoin.js         | 11 -----------
 2 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/dev/Knoin/AbstractViews.js b/dev/Knoin/AbstractViews.js
index 59d676647..4f22d4c65 100644
--- a/dev/Knoin/AbstractViews.js
+++ b/dev/Knoin/AbstractViews.js
@@ -29,8 +29,8 @@ class AbstractView {
 
 /*
 	onBuild() {}
-	onBeforeShow() {}
-	onShow() {}
+	onBeforeShow() {} // Happens before: hidden = false
+	onShow() {}       // Happens after: hidden = false
 	onHide() {}
 */
 
@@ -71,13 +71,17 @@ export class AbstractViewPopup extends AbstractView
 		shortcuts.add('backspace', '', name, inFocus());
 	}
 
+	// Happens when user hits Escape key
 	onClose() {
 		return true;
 	}
 
 /*
-	afterShow() {}
-	afterHide() {}
+	onBeforeShow() {} // Happens before showModal()
+	onShow() {}       // Happens after showModal()
+	afterShow() {}    // Happens after showModal() animation transitionend
+	onHide() {}       // Happens before animation transitionend
+	afterHide() {}    // Happens after  animation transitionend
 
 	closeCommand() {}
 */
diff --git a/dev/Knoin/Knoin.js b/dev/Knoin/Knoin.js
index 67e43ff98..840aa3212 100644
--- a/dev/Knoin/Knoin.js
+++ b/dev/Knoin/Knoin.js
@@ -103,17 +103,6 @@ const
 							vmDom.classList.remove('animate'); // trigger the transitions
 						}
 						arePopupsVisible(0 < visiblePopups.size);
-/*
-						// the old ko.bindingHandlers.modal
-						const close = vmDom.querySelector('.close'),
-							click = () => vm.modalVisibility(false);
-						if (close) {
-							close.addEventListener('click.koModal', click);
-							ko.utils.domNodeDisposal.addDisposeCallback(vmDom, () =>
-								close.removeEventListener('click.koModal', click)
-							);
-						}
-*/
 					});
 					vmDom.addEventListener('transitionend', endShowHide);
 				}