JavaScript string compare '' is always a ToBoolean

See https://www.ecma-international.org/ecma-262/5.1/#sec-9.2
This commit is contained in:
djmaze 2020-07-28 17:20:14 +02:00
parent 82bed1ed80
commit 2ba34532c2
57 changed files with 213 additions and 218 deletions

View file

@ -35,14 +35,14 @@ class ContactModel extends AbstractModel {
name = trim(property[1] + ' ' + name);
} else if (ContactPropertyType.LastName === property[0]) {
name = trim(name + ' ' + property[1]);
} else if ('' === email && ContactPropertyType.Email === property[0]) {
} else if (!email && ContactPropertyType.Email === property[0]) {
email = property[1];
}
}
});
}
return '' === email ? null : [email, name];
return email ? [email, name] : null;
}
/**