JavaScript string compare '' is always a ToBoolean

See https://www.ecma-international.org/ecma-262/5.1/#sec-9.2
This commit is contained in:
djmaze 2020-07-28 17:20:14 +02:00
parent 82bed1ed80
commit 2ba34532c2
57 changed files with 213 additions and 218 deletions

View file

@ -48,10 +48,10 @@ class MailBoxUserScreen extends AbstractScreen {
}
getApp().setWindowTitle(
('' === email
? ''
: '' + (0 < foldersInboxUnreadCount ? '(' + foldersInboxUnreadCount + ') ' : ' ') + email + ' - ') +
i18n('TITLES/MAILBOX')
(email
? '' + (0 < foldersInboxUnreadCount ? '(' + foldersInboxUnreadCount + ') ' : ' ') + email + ' - '
: ''
) + i18n('TITLES/MAILBOX')
);
}
@ -152,7 +152,7 @@ class MailBoxUserScreen extends AbstractScreen {
vals[1] = 0 >= vals[1] ? 1 : vals[1];
vals[2] = pString(vals[2]);
if ('' === request) {
if (!request) {
vals[0] = inboxFolderName;
vals[1] = 1;
}
@ -163,7 +163,7 @@ class MailBoxUserScreen extends AbstractScreen {
vals[0] = pString(vals[0]);
vals[1] = pString(vals[1]);
if ('' === request) {
if (!request) {
vals[0] = inboxFolderName;
}

View file

@ -120,7 +120,7 @@ class SettingsUserScreen extends AbstractSettingsScreen {
setSettingsTitle() {
const sEmail = AccountStore.email();
getApp().setWindowTitle(('' === sEmail ? '' : sEmail + ' - ') + this.sSettingsTitle);
getApp().setWindowTitle((sEmail ? sEmail + ' - ' : '') + this.sSettingsTitle);
}
}