JavaScript string compare '' is always a ToBoolean

See https://www.ecma-international.org/ecma-262/5.1/#sec-9.2
This commit is contained in:
djmaze 2020-07-28 17:20:14 +02:00
parent 82bed1ed80
commit 2ba34532c2
57 changed files with 213 additions and 218 deletions

View file

@ -76,9 +76,9 @@ class SecurityAdminSettings {
this.onNewAdminPasswordResponse = this.onNewAdminPasswordResponse.bind(this);
}
@command((self) => '' !== trim(self.adminLogin()) && '' !== self.adminPassword())
@command((self) => trim(self.adminLogin()) && self.adminPassword())
saveNewAdminPasswordCommand() {
if ('' === trim(this.adminLogin())) {
if (!trim(this.adminLogin())) {
this.adminLoginError(true);
return false;
}