Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-08-29 20:19:22 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

JavaScript string compare '' is always a ToBoolean

Browse source 
See https://www.ecma-international.org/ecma-262/5.1/#sec-9.2
This commit is contained in:
djmaze 2020-07-28 17:20:14 +02:00
parent 82bed1ed80
commit 2ba34532c2
57 changed files with 213 additions and 218 deletions
Download patch file Download diff file Expand all files Collapse all files

8
dev/View/User/MailBox/MessageView.js
View file

@ -297,7 +297,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
if (pic !== this.viewUserPic() && lastEmail === email) {
this.viewUserPicVisible(false);
this.viewUserPic(DATA_IMAGE_USER_DOT_PIC);
if ('' !== pic) {
if (pic) {
this.viewUserPicVisible(true);
this.viewUserPic(pic);
}
@ -386,7 +386,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
if (dom && 1 === dom.length) {
let aC = dom;
while ('' === result) {
while (!result) {
limit -= 1;
if (0 >= limit) {
break;
@ -456,7 +456,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
// return sLine ? [window.decodeURIComponent(sLine)].map(sItem => {
// var oEmailModel = new EmailModel();
// oEmailModel.parse(sItem);
// return '' !== oEmailModel.email ? oEmailModel : null;
// return oEmailModel.email ? oEmailModel : null;
// }).filter(value => !!value) : null;
// }
// ;
@ -930,7 +930,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
* @returns {void}
*/
readReceipt(oMessage) {
if (oMessage && '' !== oMessage.readReceipt()) {
if (oMessage && oMessage.readReceipt()) {
Remote.sendReadReceiptMessage(
noop,
oMessage.folderFullNameRaw,