From 2d429297adf656f28e4ab4921fb5b1938f1b3a94 Mon Sep 17 00:00:00 2001
From: djmaze <djmaze@djmaze.lan>
Date: Mon, 28 Sep 2020 10:29:58 +0200
Subject: [PATCH] Resolve https://github.com/the-djmaze/snappymail/issues/18

---
 dev/External/ko.js                                  |  7 -------
 dev/View/Popup/Plugin.js                            | 13 ++-----------
 .../v/0.0.0/app/localization/admin/_source.en.yml   |  1 -
 rainloop/v/0.0.0/app/localization/admin/de_DE.yml   |  1 -
 rainloop/v/0.0.0/app/localization/admin/en_US.yml   |  1 -
 rainloop/v/0.0.0/app/localization/admin/es_ES.yml   |  1 -
 rainloop/v/0.0.0/app/localization/admin/fr_FR.yml   |  1 -
 rainloop/v/0.0.0/app/localization/admin/nl_NL.yml   |  1 -
 .../app/templates/Views/Admin/PopupsPlugin.html     |  4 +---
 9 files changed, 3 insertions(+), 27 deletions(-)

diff --git a/dev/External/ko.js b/dev/External/ko.js
index 694adec48..5e26c1635 100644
--- a/dev/External/ko.js
+++ b/dev/External/ko.js
@@ -83,13 +83,6 @@ ko.bindingHandlers.dropdownCloser = {
 	)
 };
 
-ko.bindingHandlers.popover = {
-	init: (element, fValueAccessor) => {
-		const conf = ko.unwrap(fValueAccessor());
-		element.title = conf.content; // conf.title
-	}
-};
-
 ko.bindingHandlers.onEnter = {
 	init: (element, fValueAccessor, fAllBindingsAccessor, viewModel) => {
 		let fn = event => {
diff --git a/dev/View/Popup/Plugin.js b/dev/View/Popup/Plugin.js
index 1af53e51c..42d6027b8 100644
--- a/dev/View/Popup/Plugin.js
+++ b/dev/View/Popup/Plugin.js
@@ -28,15 +28,6 @@ class PluginPopupView extends AbstractViewNext {
 		this.hasReadme = ko.computed(() => !!this.readme());
 		this.hasConfiguration = ko.computed(() => 0 < this.configures().length);
 
-		this.readmePopoverConf = {
-			'placement': 'right',
-			'trigger': 'hover',
-			'title': i18n('POPUPS_PLUGIN/TOOLTIP_ABOUT_TITLE'),
-			'container': 'body',
-			'html': true,
-			'content': () => `<pre>${this.readme()}</pre>`
-		};
-
 		this.bDisabeCloseOnEsc = true;
 		this.sDefaultKeyScope = KeyState.All;
 
@@ -74,8 +65,8 @@ class PluginPopupView extends AbstractViewNext {
 	}
 
 	onShow(oPlugin) {
-		this.name();
-		this.readme();
+		this.name('');
+		this.readme('');
 		this.configures([]);
 
 		if (oPlugin) {
diff --git a/rainloop/v/0.0.0/app/localization/admin/_source.en.yml b/rainloop/v/0.0.0/app/localization/admin/_source.en.yml
index b813a1946..f0ec834aa 100644
--- a/rainloop/v/0.0.0/app/localization/admin/_source.en.yml
+++ b/rainloop/v/0.0.0/app/localization/admin/_source.en.yml
@@ -200,7 +200,6 @@ en:
     DESC_NOTHING_TO_CONFIGURE: "Nothing to configure"
     BUTTON_CLOSE: "Close"
     BUTTON_SAVE: "Save"
-    TOOLTIP_ABOUT_TITLE: "About"
   POPUPS_ASK:
     DESC_WANT_CLOSE_THIS_WINDOW: "Are you sure you want to close this window?"
   POPUPS_LANGUAGES:
diff --git a/rainloop/v/0.0.0/app/localization/admin/de_DE.yml b/rainloop/v/0.0.0/app/localization/admin/de_DE.yml
index 0c016a396..47db31ce6 100644
--- a/rainloop/v/0.0.0/app/localization/admin/de_DE.yml
+++ b/rainloop/v/0.0.0/app/localization/admin/de_DE.yml
@@ -197,7 +197,6 @@ de_DE:
     DESC_NOTHING_TO_CONFIGURE: "Nichts zu konfigurieren"
     BUTTON_CLOSE: "Schließen"
     BUTTON_SAVE: "Speichern"
-    TOOLTIP_ABOUT_TITLE: "Über"
   POPUPS_ASK:
     DESC_WANT_CLOSE_THIS_WINDOW: "Sind Sie sicher, dass Sie dieses Fenster schließen möchten?"
   POPUPS_LANGUAGES:
diff --git a/rainloop/v/0.0.0/app/localization/admin/en_US.yml b/rainloop/v/0.0.0/app/localization/admin/en_US.yml
index 59ea704ce..f88d53904 100644
--- a/rainloop/v/0.0.0/app/localization/admin/en_US.yml
+++ b/rainloop/v/0.0.0/app/localization/admin/en_US.yml
@@ -197,7 +197,6 @@ en_US:
     DESC_NOTHING_TO_CONFIGURE: "Nothing to configure"
     BUTTON_CLOSE: "Close"
     BUTTON_SAVE: "Save"
-    TOOLTIP_ABOUT_TITLE: "About"
   POPUPS_ASK:
     DESC_WANT_CLOSE_THIS_WINDOW: "Are you sure you want to close this window?"
   POPUPS_LANGUAGES:
diff --git a/rainloop/v/0.0.0/app/localization/admin/es_ES.yml b/rainloop/v/0.0.0/app/localization/admin/es_ES.yml
index b9c5c9935..dd5ca76d6 100644
--- a/rainloop/v/0.0.0/app/localization/admin/es_ES.yml
+++ b/rainloop/v/0.0.0/app/localization/admin/es_ES.yml
@@ -194,7 +194,6 @@ es_ES:
     DESC_NOTHING_TO_CONFIGURE: "Nada para configurar"
     BUTTON_CLOSE: "Cerrar"
     BUTTON_SAVE: "Guardar"
-    TOOLTIP_ABOUT_TITLE: "Acerca"
   POPUPS_ASK:
     DESC_WANT_CLOSE_THIS_WINDOW: "¿Estás seguro de que deseas cerrar esta ventana?"
   POPUPS_LANGUAGES:
diff --git a/rainloop/v/0.0.0/app/localization/admin/fr_FR.yml b/rainloop/v/0.0.0/app/localization/admin/fr_FR.yml
index daac1a493..d027995bf 100644
--- a/rainloop/v/0.0.0/app/localization/admin/fr_FR.yml
+++ b/rainloop/v/0.0.0/app/localization/admin/fr_FR.yml
@@ -198,7 +198,6 @@ fr_FR:
     DESC_NOTHING_TO_CONFIGURE: "Rien à configurer"
     BUTTON_CLOSE: "Fermer"
     BUTTON_SAVE: "Enregistrer"
-    TOOLTIP_ABOUT_TITLE: "A propos"
   POPUPS_ASK:
     DESC_WANT_CLOSE_THIS_WINDOW: "Êtes-vous sûr de vouloir fermer cette fenêtre ?"
   POPUPS_LANGUAGES:
diff --git a/rainloop/v/0.0.0/app/localization/admin/nl_NL.yml b/rainloop/v/0.0.0/app/localization/admin/nl_NL.yml
index 8e8084450..33a46fc5e 100644
--- a/rainloop/v/0.0.0/app/localization/admin/nl_NL.yml
+++ b/rainloop/v/0.0.0/app/localization/admin/nl_NL.yml
@@ -197,7 +197,6 @@ nl_NL:
     DESC_NOTHING_TO_CONFIGURE: "Niets om te configureren"
     BUTTON_CLOSE: "Annuleer"
     BUTTON_SAVE: "Opslaan"
-    TOOLTIP_ABOUT_TITLE: "Over"
   POPUPS_ASK:
     DESC_WANT_CLOSE_THIS_WINDOW: "Weet u zeker dat u dit venster wilt stuiten?"
   POPUPS_LANGUAGES:
diff --git a/rainloop/v/0.0.0/app/templates/Views/Admin/PopupsPlugin.html b/rainloop/v/0.0.0/app/templates/Views/Admin/PopupsPlugin.html
index 9eeba4784..2ef2b2610 100644
--- a/rainloop/v/0.0.0/app/templates/Views/Admin/PopupsPlugin.html
+++ b/rainloop/v/0.0.0/app/templates/Views/Admin/PopupsPlugin.html
@@ -6,6 +6,7 @@
 			&nbsp;
 			"<span data-bind="text: name"></span>"
 		</h4>
+		<span data-bind="visible: hasReadme, text: readme"></span>
 	</div>
 	<div class="modal-body">
 		<form class="form-horizontal plugin-form" action="#/" onsubmit="return false;">
@@ -22,9 +23,6 @@
 		</form>
 	</div>
 	<div class="modal-footer">
-		<span class="information pull-left" data-bind="visible: hasReadme, popover: readmePopoverConf">
-			<i class="icon-info"></i>
-		</span>
 		<a class="btn buttonClose" data-bind="command: cancelCommand">
 			<i class="icon-remove"></i>
 			&nbsp;&nbsp;