Move setupSettings() in constructor

This commit is contained in:
djmaze 2021-09-23 09:44:46 +02:00
parent c9fe7516c4
commit 2dfa0b5f0e
3 changed files with 4 additions and 18 deletions

View file

@ -18,12 +18,8 @@ export class AbstractSettingsScreen extends AbstractScreen {
this.menu = ko.observableArray();
this.oCurrentSubScreen = null;
this.setupSettings();
}
setupSettings() {}
onRoute(subName) {
let settingsScreen = null,
viewModelDom = null,

View file

@ -17,9 +17,7 @@ import { PaneSettingsAdminView } from 'View/Admin/Settings/Pane';
export class SettingsAdminScreen extends AbstractSettingsScreen {
constructor() {
super([MenuSettingsAdminView, PaneSettingsAdminView]);
}
setupSettings() {
settingsAddViewModel(
GeneralAdminSettings,
'AdminSettingsGeneral',

View file

@ -26,17 +26,6 @@ export class SettingsUserScreen extends AbstractSettingsScreen {
constructor() {
super([SystemDropDownSettingsUserView, MenuSettingsUserView, PaneSettingsUserView]);
initOnStartOrLangChange(
() => this.sSettingsTitle = i18n('TITLES/SETTINGS'),
() => this.setSettingsTitle()
);
}
setupSettings() {
if (!Settings.capa(Capa.Settings)) {
return false;
}
settingsAddViewModel(GeneralUserSettings, 'SettingsGeneral', 'SETTINGS_LABELS/LABEL_GENERAL_NAME', 'general', true);
if (AppUserStore.allowContacts()) {
@ -74,7 +63,10 @@ export class SettingsUserScreen extends AbstractSettingsScreen {
runSettingsViewModelHooks(false);
return true;
initOnStartOrLangChange(
() => this.sSettingsTitle = i18n('TITLES/SETTINGS'),
() => this.setSettingsTitle()
);
}
onShow() {