Dereku/snappymail
0
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-10-31 09:33:33 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

KnockoutJS:

Browse source 
* remove deprecated allBindings as Accessor https://github.com/knockout/knockout/pull/2133
* remove unused event '*Bubble' https://knockoutjs.com/documentation/event-binding.html#note-4-preventing-the-event-from-bubbling
* remove unused 'completeOn' https://knockoutjs.com/documentation/binding-lifecycle-events.html#indicating-that-a-control-flow-binding-completes-asynchronously
This commit is contained in:
djmaze 2021-08-10 15:00:49 +02:00
parent 4cb88b408c
commit 3a32a09f2a
8 changed files with 96 additions and 116 deletions
Download patch file Download diff file Expand all files Collapse all files

6
vendors/knockout/src/binding/defaultBindings/event.js vendored
View file

@ -33,12 +33,6 @@ ko.bindingHandlers['event'] = {
event.preventDefault();
}
}
var bubble = allBindings.get(eventName + 'Bubble') !== false;
if (!bubble) {
event.cancelBubble = true;
event.stopPropagation();
}
});
}
});

9
vendors/knockout/src/binding/defaultBindings/ifIfnotWith.js vendored
View file

@ -4,7 +4,7 @@
function makeWithIfBinding(bindingKey, isWith, isNot) {
ko.bindingHandlers[bindingKey] = {
'init': (element, valueAccessor, allBindings, viewModel, bindingContext) => {
var didDisplayOnLastUpdate, savedNodes, contextOptions = {}, completeOnRender, needAsyncContext, renderOnEveryChange;
var didDisplayOnLastUpdate, savedNodes, contextOptions = {}, needAsyncContext, renderOnEveryChange;
if (isWith) {
var as = allBindings.get('as'), noChildContext = allBindings.get('noChildContext');
@ -12,8 +12,7 @@ function makeWithIfBinding(bindingKey, isWith, isNot) {
contextOptions = { 'as': as, 'noChildContext': noChildContext, 'exportDependencies': renderOnEveryChange };
}
completeOnRender = allBindings.get("completeOn") == "render";
needAsyncContext = completeOnRender || allBindings['has'](ko.bindingEvent.descendantsComplete);
needAsyncContext = allBindings['has'](ko.bindingEvent.descendantsComplete);
ko.computed(() => {
var value = ko.utils.unwrapObservable(valueAccessor()),
@ -57,9 +56,7 @@ function makeWithIfBinding(bindingKey, isWith, isNot) {
} else {
ko.virtualElements.emptyNode(element);
if (!completeOnRender) {
ko.bindingEvent.notify(element, ko.bindingEvent.childrenComplete);
}
ko.bindingEvent.notify(element, ko.bindingEvent.childrenComplete);
}
didDisplayOnLastUpdate = shouldDisplay;