Add more strict rules (eslint)

This commit is contained in:
RainLoop Team 2016-07-02 01:49:59 +03:00
parent b43bb17cdb
commit 52e2698cdf
38 changed files with 488 additions and 434 deletions

View file

@ -916,7 +916,7 @@ ComposePopupView.prototype.converSignature = function(sSignature)
sSignature = sSignature.replace(/{{MOMENT:[^}]+}}/g, '');
}
catch (e) {/* eslint-disable-line no-empty */}
catch (e) {} // eslint-disable-line no-empty
}
return sSignature;
@ -1324,7 +1324,7 @@ ComposePopupView.prototype.onMessageUploadAttachments = function(sResult, oData)
{
for (sTempName in oData.Result)
{
if (oData.Result.hasOwnProperty(sTempName))
if (Utils.has(oData.Result, oData.Result))
{
oAttachment = this.getAttachmentById(oData.Result[sTempName]);
if (oAttachment)

View file

@ -695,8 +695,9 @@ MessageViewMailBoxUserView.prototype.onBuild = function(oDom)
oDom
.on('click', 'a', function(oEvent) {
// setup maito protocol
return !(!!oEvent && 3 !== oEvent.which && Utils.mailToHelper($(this).attr('href'),
Settings.capa(Enums.Capa.Composer) ? require('View/Popup/Compose') : null));
return !(!!oEvent && 3 !== oEvent.which && Utils.mailToHelper(
$(this).attr('href'), Settings.capa(Enums.Capa.Composer) ? require('View/Popup/Compose') : null
));
})
// .on('mouseover', 'a', _.debounce(function(oEvent) {
//

View file

@ -35,11 +35,6 @@ _.extend(MenuSettingsUserView.prototype, AbstractView.prototype);
MenuSettingsUserView.prototype.onBuild = function(oDom)
{
// var self = this;
// key('esc', Enums.KeyState.Settings, function() {
// self.backToMailBoxClick();
// });
if (this.mobile)
{
oDom
@ -75,7 +70,7 @@ MenuSettingsUserView.prototype.onBuild = function(oDom)
}
}
}, 200));
}, 200)); // eslint-disable-line no-magic-numbers
};
MenuSettingsUserView.prototype.link = function(sRoute)