From 52e6b9b0edbdf0e6f2151421a8d8c6b6c91ff27d Mon Sep 17 00:00:00 2001 From: the-djmaze <3752035+the-djmaze@users.noreply.github.com> Date: Sun, 11 Oct 2020 00:27:45 +0200 Subject: [PATCH] Knockout visibleHidden to HTML5 --- .../src/binding/defaultBindings/visibleHidden.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/vendors/knockout/src/binding/defaultBindings/visibleHidden.js b/vendors/knockout/src/binding/defaultBindings/visibleHidden.js index f403111bf..d9b87d862 100644 --- a/vendors/knockout/src/binding/defaultBindings/visibleHidden.js +++ b/vendors/knockout/src/binding/defaultBindings/visibleHidden.js @@ -1,15 +1,9 @@ ko.bindingHandlers['visible'] = { - 'update': (element, valueAccessor) => { - var value = ko.utils.unwrapObservable(valueAccessor()); - var isCurrentlyVisible = !(element.style.display == "none"); - if (value && !isCurrentlyVisible) - element.style.display = ""; - else if ((!value) && isCurrentlyVisible) - element.style.display = "none"; - } + 'update': (element, valueAccessor) => + element.hidden = !ko.utils.unwrapObservable(valueAccessor()) }; ko.bindingHandlers['hidden'] = { 'update': (element, valueAccessor) => - ko.bindingHandlers['visible']['update'](element, () => !ko.utils.unwrapObservable(valueAccessor()) ) + element.hidden = !!ko.utils.unwrapObservable(valueAccessor()) };