From 62bda28a28c36ca6412f33915f8c33edee9e7301 Mon Sep 17 00:00:00 2001 From: the-djmaze <> Date: Sun, 3 Mar 2024 18:11:15 +0100 Subject: [PATCH] KnockoutJS drop unused `dontLimitMoves` --- .../src/binding/editDetection/arrayToDomNodeChildren.js | 1 - vendors/knockout/src/binding/editDetection/compareArrays.js | 5 +---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/vendors/knockout/src/binding/editDetection/arrayToDomNodeChildren.js b/vendors/knockout/src/binding/editDetection/arrayToDomNodeChildren.js index c687e344f..fe9f19524 100644 --- a/vendors/knockout/src/binding/editDetection/arrayToDomNodeChildren.js +++ b/vendors/knockout/src/binding/editDetection/arrayToDomNodeChildren.js @@ -87,7 +87,6 @@ Array.prototype.map.call(lastMappingResult, x => x.arrayEntry), array, { - 'dontLimitMoves': options['dontLimitMoves'], 'sparse': true }); } diff --git a/vendors/knockout/src/binding/editDetection/compareArrays.js b/vendors/knockout/src/binding/editDetection/compareArrays.js index e5d9032ec..a9085f6bc 100644 --- a/vendors/knockout/src/binding/editDetection/compareArrays.js +++ b/vendors/knockout/src/binding/editDetection/compareArrays.js @@ -78,16 +78,13 @@ ko.utils.compareArrays = (() => { // Set a limit on the number of consecutive non-matching comparisons; having it a multiple of // smlIndexMax keeps the time complexity of this algorithm linear. - ko.utils.findMovesInArrayComparison(notInBig, notInSml, !options['dontLimitMoves'] && smlIndexMax * 10); + ko.utils.findMovesInArrayComparison(notInBig, notInSml, smlIndexMax * 10); return editScript.reverse(); }; // Simple calculation based on Levenshtein distance. return (oldArray, newArray, options) => { - // For backward compatibility, if the third arg is actually a bool, interpret - // it as the old parameter 'dontLimitMoves'. Newer code should use { dontLimitMoves: true }. - options = (typeof options === 'boolean') ? { 'dontLimitMoves': options } : (options || {}); oldArray = oldArray || []; newArray = newArray || [];