there's not type hint 'resource' (bug in my converter)

https://wiki.php.net/rfc/scalar_type_hints#type_hint_choices
This commit is contained in:
djmaze 2020-03-11 15:42:46 +01:00
parent 69a33c0c25
commit 690190bb26
8 changed files with 12 additions and 11 deletions

View file

@ -140,8 +140,8 @@ class HeaderCollection extends \MailSo\Base\Collection
$aResult = $this->FilterList(function ($oHeader) use ($sHeaderName) {
return $oHeader && \strtolower($oHeader->Name()) !== \strtolower($sHeaderName);
});
return $this->SetAsArray($aResult);
$this->SetAsArray($aResult);
return $this;
}
/**

View file

@ -5376,7 +5376,7 @@ NewThemeLink IncludeCss LoadingDescriptionEsc TemplatesLink LangLink IncludeBack
* @throws \MailSo\Net\Exceptions\ConnectionException
*/
private function smtpSendMessage(\RainLoop\Model\Account $oAccount, \MailSo\Mime\Message $oMessage,
resource &$rMessageStream, int &$iMessageStreamSize, bool $bDsn = false, bool $bAddHiddenRcpt = true)
/*resource*/ &$rMessageStream, int &$iMessageStreamSize, bool $bDsn = false, bool $bAddHiddenRcpt = true)
{
$oRcpt = $oMessage->GetRcpt();
if ($oRcpt && 0 < $oRcpt->Count())
@ -6958,7 +6958,7 @@ NewThemeLink IncludeCss LoadingDescriptionEsc TemplatesLink LangLink IncludeBack
return $this->DefaultResponse(__FUNCTION__, $mResponse);
}
private function importContactsFromCsvFile(\RainLoop\Model\Account $oAccount, resource $rFile, string $sFileStart) : int
private function importContactsFromCsvFile(\RainLoop\Model\Account $oAccount, /*resource*/ $rFile, string $sFileStart) : int
{
$iCount = 0;
$aHeaders = null;
@ -7011,7 +7011,7 @@ NewThemeLink IncludeCss LoadingDescriptionEsc TemplatesLink LangLink IncludeBack
return $iCount;
}
private function importContactsFromVcfFile(\RainLoop\Model\Account $oAccount, resource $rFile) : int
private function importContactsFromVcfFile(\RainLoop\Model\Account $oAccount, /*resource*/ $rFile) : int
{
$iCount = 0;
if ($oAccount && \is_resource($rFile))

View file

@ -14,7 +14,7 @@ class Files extends \RainLoop\Providers\AbstractProvider
$this->oDriver = $oDriver;
}
public function PutFile(\RainLoop\Model\Account $oAccount, string $sKey, resource $rSource) : bool
public function PutFile(\RainLoop\Model\Account $oAccount, string $sKey, /*resource*/ $rSource) : bool
{
return $this->oDriver->PutFile($oAccount, $sKey, $rSource);
}

View file

@ -25,7 +25,7 @@ class FileStorage implements \RainLoop\Providers\Files\IFiles
return $this->generateFullFileName($oAccount, $sKey, true);
}
public function PutFile(\RainLoop\Model\Account $oAccount, string $sKey, resource $rSource) : bool
public function PutFile(\RainLoop\Model\Account $oAccount, string $sKey, /*resource*/ $rSource) : bool
{
$bResult = false;
if ($rSource)

View file

@ -6,7 +6,7 @@ interface IFiles
{
public function GenerateLocalFullFileName(\RainLoop\Model\Account $oAccount, string $sKey) : string;
public function PutFile(\RainLoop\Model\Account $oAccount, string $sKey, resource $rSource) : bool;
public function PutFile(\RainLoop\Model\Account $oAccount, string $sKey, /*resource*/ $rSource) : bool;
public function MoveUploadedFile(\RainLoop\Model\Account $oAccount, string $sKey, string $sSource) : bool;

View file

@ -172,7 +172,7 @@ class ServiceActions
{
error_log($oException->getMessage());
if ($e = $oException->getPrevious()) {
error_log("\t".$e->getMessage());
error_log("\t{$e->getMessage()} @ {$e->getFile()}#{$e->getLine()}");
}
$aResponseItem = $this->oActions->ExceptionResponse(

View file

@ -14,7 +14,9 @@
<meta name="google" content="notranslate" />
<meta name="robots" content="noindex,nofollow,noodp" />
<meta name="AppBootData" content='{{RainloopBootData}}' id="app-boot-data" />
<!--
<script type="text/javascript" data-cfasync="false" src="{{BaseAppPolyfillsScriptLink}}"></script>
-->
{{BaseContentSecurityPolicy}}
<title></title>
{{BaseAppHeadScriptLink}}

View file

@ -174,8 +174,7 @@
<div class="btn-group pull-right">
<a class="btn first" data-tooltip-join="bottom"
style="padding-left: 10px; padding-right: 10px;"
data-bind="visible: addAttachmentEnabled(), initDom: composeUploaderButton, tooltip: 'COMPOSE/ATTACH_FILES',
css: {'last': !(driveEnabled() && driveVisible())}">
data-bind="visible: addAttachmentEnabled(), initDom: composeUploaderButton, tooltip: 'COMPOSE/ATTACH_FILES'">
<sup style="font-weight: bold; font-size: 100%; top: -0.3em;">+</sup><i class="icon-attachment"></i>
</a>
</div>