From 81d521c562542042ed1ac0b7af0769f93fa316b8 Mon Sep 17 00:00:00 2001
From: the-djmaze <>
Date: Tue, 21 Feb 2023 14:26:16 +0100
Subject: [PATCH] Simplify folder name editing

---
 dev/Model/FolderCollection.js                             | 8 ++++++++
 dev/Settings/User/Folders.js                              | 8 --------
 .../app/templates/Views/User/SettingsFolderItem.html      | 4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/dev/Model/FolderCollection.js b/dev/Model/FolderCollection.js
index badab8798..7a8f06849 100644
--- a/dev/Model/FolderCollection.js
+++ b/dev/Model/FolderCollection.js
@@ -465,6 +465,14 @@ export class FolderModel extends AbstractModel {
 		});
 	}
 
+	edit() {
+		this.canBeEdited() && this.editing(true);
+	}
+
+	unedit() {
+		this.editing(false);
+	}
+
 	/**
 	 * For url safe '/#/mailbox/...' path
 	 */
diff --git a/dev/Settings/User/Folders.js b/dev/Settings/User/Folders.js
index f00c891a1..73e68b6dd 100644
--- a/dev/Settings/User/Folders.js
+++ b/dev/Settings/User/Folders.js
@@ -52,8 +52,6 @@ export class UserSettingsFolders /*extends AbstractViewSettings*/ {
 
 		this.folderForDeletion = folderForDeletion;
 
-		this.folderForEdit = ko.observable(null).extend({ toggleSubscribeProperty: [this, 'editing'] });
-
 		SettingsUserStore.hideUnsubscribed.subscribe(value => Remote.saveSetting('HideUnsubscribed', value));
 		SettingsUserStore.unhideKolabFolders.subscribe(value => Remote.saveSetting('UnhideKolabFolders', value));
 	}
@@ -89,15 +87,9 @@ export class UserSettingsFolders /*extends AbstractViewSettings*/ {
 				});
 		}
 
-//		this.folderForEdit(null);
 		folder.editing(false);
 	}
 
-	folderEditOnEsc(folder) {
-//		this.folderForEdit(null);
-		folder?.editing(false);
-	}
-
 	onShow() {
 		FolderUserStore.folderListError('');
 	}
diff --git a/snappymail/v/0.0.0/app/templates/Views/User/SettingsFolderItem.html b/snappymail/v/0.0.0/app/templates/Views/User/SettingsFolderItem.html
index 9e5357f2d..c598e694a 100644
--- a/snappymail/v/0.0.0/app/templates/Views/User/SettingsFolderItem.html
+++ b/snappymail/v/0.0.0/app/templates/Views/User/SettingsFolderItem.html
@@ -1,11 +1,11 @@
 <tr data-bind="css: { 'selectable': selectable, 'system': isSystemFolder }">
 	<td data-bind="css: 'deep-' + deep">
 		<span class="folder-name" data-bind="text: name, visible: !editing(), css: { 'can-be-edited': canBeEdited },
-			click: function (oFolder) { oFolder.canBeEdited() && $root.folderForEdit(oFolder); },
+			click: edit,
 			tooltipErrorTip: errorMsg"></span>
 		<input type="text"
 			autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"
-			data-bind="value: nameForEdit, visible: editing, hasfocus: editing, onEnter: function () { $root.folderEditOnEnter($data); }, onEsc: function () { $root.folderEditOnEsc($data); }">
+			data-bind="value: nameForEdit, visible: editing, hasfocus: editing, onEnter: function () { $root.folderEditOnEnter($data); }, onEsc: unedit">
 		&nbsp;
 		<span class="folder-system-name" data-bind="text: manageFolderSystemName, visible: isSystemFolder"></span>
 	</td>