Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-08-30 12:39:20 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup array.length checks and for() to forEach()

Browse source
This commit is contained in:
djmaze 2020-07-28 12:35:41 +02:00
parent db5751cd00
commit 82bed1ed80
24 changed files with 135 additions and 169 deletions
Download patch file Download diff file Expand all files Collapse all files

4
dev/Stores/User/Folder.js
View file

@ -72,7 +72,7 @@ class FolderUserStore {
trashFolder = this.trashFolder(),
archiveFolder = this.archiveFolder();
if (isArray(folders) && 0 < folders.length) {
if (isArray(folders) && folders.length) {
if ('' !== sentFolder && UNUSED_OPTION_VALUE !== sentFolder) {
list.push(sentFolder);
}
@ -174,7 +174,7 @@ class FolderUserStore {
timeouts.push([folder.interval, folder.fullNameRaw]);
}
if (folder && 0 < folder.subFolders().length) {
if (folder && folder.subFolders().length) {
fSearchFunction(folder.subFolders());
}
});

15
dev/Stores/User/Message.js
View file

@ -249,7 +249,7 @@ class MessageUserStore {
initUidNextAndNewMessages(folder, uidNext, newMessages) {
if (getFolderInboxName() === folder && isNormal(uidNext) && '' !== uidNext) {
if (isArray(newMessages) && 0 < newMessages.length) {
if (isArray(newMessages) && newMessages.length) {
newMessages.forEach(item => {
addNewMessageCache(folder, item.Uid);
});
@ -343,7 +343,7 @@ class MessageUserStore {
toFolder.actionBlink(true);
}
if (0 < messages.length) {
if (messages.length) {
if (copy) {
messages.forEach(item => {
item.checked(false);
@ -381,7 +381,7 @@ class MessageUserStore {
if (
messageList &&
0 < messageList.length &&
messageList.length &&
!!messageList.find(item => !!(item && item.deleted() && item.uid === this.messageListThreadUid()))
) {
const message = messageList.find(item => item && !item.deleted());
@ -436,15 +436,10 @@ class MessageUserStore {
initBlockquoteSwitcher(messageTextBody) {
if (messageTextBody) {
const $oList = $('blockquote:not(.rl-bq-switcher)', messageTextBody).filter(function() {
return (
0 ===
$(this)
.parent()
.closest('blockquote', messageTextBody).length
); // eslint-disable-line no-invalid-this
return !$(this).parent().closest('blockquote', messageTextBody).length;
});
if ($oList && 0 < $oList.length) {
if ($oList && $oList.length) {
$oList.each(function() {
const $this = $(this); // eslint-disable-line no-invalid-this

8
dev/Stores/User/Pgp.js
View file

@ -63,7 +63,7 @@ class PgpUserStore {
}).flat().filter(value => !!value)
: [];
if (0 === result.length && isNonEmptyArray(recipients)) {
if (!result.length && isNonEmptyArray(recipients)) {
result = recipients.map(sEmail => {
const keys = sEmail ? this.findAllPrivateKeysByEmailNotNative(sEmail) : null;
return keys
@ -143,7 +143,7 @@ class PgpUserStore {
decryptMessage(message, recipients, fCallback) {
if (message && message.getEncryptionKeyIds) {
const privateKeys = this.findPrivateKeysByEncryptionKeyIds(message.getEncryptionKeyIds(), recipients, true);
if (privateKeys && 0 < privateKeys.length) {
if (privateKeys && privateKeys.length) {
showScreenPopup(require('View/Popup/MessageOpenPgp'), [
(decryptedKey) => {
if (decryptedKey) {
@ -186,9 +186,9 @@ class PgpUserStore {
verifyMessage(message, fCallback) {
if (message && message.getSigningKeyIds) {
const signingKeyIds = message.getSigningKeyIds();
if (signingKeyIds && 0 < signingKeyIds.length) {
if (signingKeyIds && signingKeyIds.length) {
const publicKeys = this.findPublicKeysBySigningKeyIds(signingKeyIds);
if (publicKeys && 0 < publicKeys.length) {
if (publicKeys && publicKeys.length) {
try {
const result = message.verify(publicKeys),
valid = (_.isArray(result) ? result : []).find(item => item && item.valid && item.keyid);

2
dev/Stores/User/Template.js
View file

@ -23,7 +23,7 @@ class TemplateUserStore {
// {
// this.templatesNames.skipFirst = false;
// }
// else if (aList && 1 < aList.length)
// else if (aList && aList.length)
// {
// Remote.templatesSortOrder(null, aList);
// }