Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-08-29 20:19:22 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup array.length checks and for() to forEach()

Browse source
This commit is contained in:
djmaze 2020-07-28 12:35:41 +02:00
parent db5751cd00
commit 82bed1ed80
24 changed files with 135 additions and 169 deletions
Download patch file Download diff file Expand all files Collapse all files

15
dev/Stores/User/Message.js
View file

@ -249,7 +249,7 @@ class MessageUserStore {
initUidNextAndNewMessages(folder, uidNext, newMessages) {
if (getFolderInboxName() === folder && isNormal(uidNext) && '' !== uidNext) {
if (isArray(newMessages) && 0 < newMessages.length) {
if (isArray(newMessages) && newMessages.length) {
newMessages.forEach(item => {
addNewMessageCache(folder, item.Uid);
});
@ -343,7 +343,7 @@ class MessageUserStore {
toFolder.actionBlink(true);
}
if (0 < messages.length) {
if (messages.length) {
if (copy) {
messages.forEach(item => {
item.checked(false);
@ -381,7 +381,7 @@ class MessageUserStore {
if (
messageList &&
0 < messageList.length &&
messageList.length &&
!!messageList.find(item => !!(item && item.deleted() && item.uid === this.messageListThreadUid()))
) {
const message = messageList.find(item => item && !item.deleted());
@ -436,15 +436,10 @@ class MessageUserStore {
initBlockquoteSwitcher(messageTextBody) {
if (messageTextBody) {
const $oList = $('blockquote:not(.rl-bq-switcher)', messageTextBody).filter(function() {
return (
0 ===
$(this)
.parent()
.closest('blockquote', messageTextBody).length
); // eslint-disable-line no-invalid-this
return !$(this).parent().closest('blockquote', messageTextBody).length;
});
if ($oList && 0 < $oList.length) {
if ($oList && $oList.length) {
$oList.each(function() {
const $this = $(this); // eslint-disable-line no-invalid-this