Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-07-10 06:58:27 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup array.length checks and for() to forEach()

Browse source
This commit is contained in:
djmaze 2020-07-28 12:35:41 +02:00
parent db5751cd00
commit 82bed1ed80
24 changed files with 135 additions and 169 deletions
Download patch file Download diff file Expand all files Collapse all files

25
dev/View/User/MailBox/MessageList.js
View file

@ -163,9 +163,8 @@ class MessageListMailBoxUserView extends AbstractViewNext {
});
this.isIncompleteChecked = ko.computed(() => {
const m = MessageStore.messageList().length,
c = MessageStore.messageListChecked().length;
return 0 < m && 0 < c && m > c;
const c = MessageStore.messageListChecked().length;
return c && MessageStore.messageList().length > c;
});
this.hasMessages = ko.computed(() => 0 < this.messageList().length);
@ -209,13 +208,11 @@ class MessageListMailBoxUserView extends AbstractViewNext {
);
this.mobileCheckedStateShow = ko.computed(() => {
const checked = 0 < this.messageListChecked().length;
return this.mobile ? checked : true;
return this.mobile ? 0 < this.messageListChecked().length : true;
});
this.mobileCheckedStateHide = ko.computed(() => {
const checked = 0 < this.messageListChecked().length;
return this.mobile ? !checked : true;
return this.mobile ? !this.messageListChecked().length : true;
});
this.messageListFocused = ko.computed(() => Focused.MessageList === AppStore.focusedState());
@ -399,7 +396,7 @@ class MessageListMailBoxUserView extends AbstractViewNext {
}
goToUpUpOrDownDown(up) {
if (0 < this.messageListChecked().length) {
if (this.messageListChecked().length) {
return false;
}
@ -652,7 +649,7 @@ class MessageListMailBoxUserView extends AbstractViewNext {
const checked = this.messageListCheckedOrSelected();
if (currentMessage) {
const checkedUids = checked.map(message => message.uid);
if (0 < checkedUids.length && checkedUids.includes(currentMessage.uid)) {
if (checkedUids.includes(currentMessage.uid)) {
this.setAction(
currentMessage.folderFullNameRaw,
currentMessage.flagged() ? MessageSetAction.UnsetFlag : MessageSetAction.SetFlag,
@ -670,7 +667,7 @@ class MessageListMailBoxUserView extends AbstractViewNext {
flagMessagesFast(bFlag) {
const checked = this.messageListCheckedOrSelected();
if (0 < checked.length) {
if (checked.length) {
if (isUnd(bFlag)) {
const flagged = checked.filter(message => message.flagged());
this.setAction(
@ -690,12 +687,12 @@ class MessageListMailBoxUserView extends AbstractViewNext {
seenMessagesFast(seen) {
const checked = this.messageListCheckedOrSelected();
if (0 < checked.length) {
if (checked.length) {
if (isUnd(seen)) {
const unseen = checked.filter(message => message.unseen());
this.setAction(
checked[0].folderFullNameRaw,
0 < unseen.length ? MessageSetAction.SetSeen : MessageSetAction.UnsetSeen,
unseen.length ? MessageSetAction.SetSeen : MessageSetAction.UnsetSeen,
checked
);
} else {
@ -734,7 +731,7 @@ class MessageListMailBoxUserView extends AbstractViewNext {
'' === this.messageListSearchDesc() &&
'' === this.messageListError() &&
'' === this.messageListEndThreadUid() &&
0 < this.messageList().length &&
this.messageList().length &&
(this.isSpamFolder() || this.isTrashFolder())
);
}
@ -811,7 +808,7 @@ class MessageListMailBoxUserView extends AbstractViewNext {
// delete
key('delete, shift+delete, shift+3', KeyState.MessageList, (event, handler) => {
if (event) {
if (0 < MessageStore.messageListCheckedOrSelected().length) {
if (MessageStore.messageListCheckedOrSelected().length) {
if (handler && 'shift+delete' === handler.shortcut) {
this.deleteWithoutMoveCommand();
} else {

6
dev/View/User/MailBox/MessageView.js
View file

@ -130,7 +130,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
};
this.allowAttachmnetControls = ko.computed(
() => 0 < this.attachmentsActions().length && Settings.capa(Capa.AttachmentsActions)
() => this.attachmentsActions().length && Settings.capa(Capa.AttachmentsActions)
);
this.downloadAsZipAllowed = ko.computed(
@ -496,7 +496,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
return null;
}).filter(value => !!value);
if (0 < dynamicEls.length) {
if (dynamicEls.length) {
div.on('onBeforeOpen.lg', () => {
useKeyboardShortcuts(false);
removeInFocus(true);
@ -888,7 +888,7 @@ class MessageViewMailBoxUserView extends AbstractViewNext {
downloadAsZip() {
const hashes = this.getAttachmentsHashes();
if (0 < hashes.length) {
if (hashes.length) {
Promises.attachmentsActions('Zip', hashes, this.downloadAsZipLoading)
.then((result) => {
if (result && result.Result && result.Result.Files && result.Result.Files[0] && result.Result.Files[0].Hash) {