Better solution for #298

dev/Common/Fullscreen.js

@@ -0,0 +1,23 @@
+import { doc, elementById, $htmlCL } from 'Common/Globals';
+
+// Fullscreen must be on app, else other popups fail
+export const
+	app = elementById('rl-app'),
+	appFullscreen = () => (doc.fullscreenElement || doc.webkitFullscreenElement) === app,
+	exitFullscreen = () => appFullscreen() && (doc.exitFullscreen || doc.webkitExitFullscreen).call(doc),
+	isFullscreen = ko.observable(false),
+	toggleFullscreen = () => isFullscreen() ? exitFullscreen() : app.requestFullscreen();
+
+if (app) {
+	let event = 'fullscreenchange';
+	if (!app.requestFullscreen && app.webkitRequestFullscreen) {
+		app.requestFullscreen = app.webkitRequestFullscreen;
+		event = 'webkit'+event;
+	}
+	if (app.requestFullscreen) {
+		doc.addEventListener(event, () => {
+			isFullscreen(appFullscreen());
+			$htmlCL.toggle('rl-fullscreen', appFullscreen());
+		});
+	}
+}

dev/Common/Globals.js

@@ -11,13 +11,6 @@ export const
 
 	elementById = id => doc.getElementById(id),
 
-	// Fullscreen must be on app, else other popups fail
-	app = doc.getElementById('rl-app'),
-	appFullscreen = () => (doc.fullscreenElement || doc.webkitFullscreenElement) === app,
-	exitFullscreen = () => appFullscreen() && (doc.exitFullscreen || doc.webkitExitFullscreen).call(doc),
-	isFullscreen = ko.observable(false),
-	toggleFullscreen = () => isFullscreen() ? exitFullscreen() : app.requestFullscreen(),
-
 	Settings = rl.settings,
 	SettingsGet = Settings.get,
 	SettingsCapa = Settings.capa,
@@ -65,20 +58,6 @@ export const
 		shortcuts.setScope(value);
 	};
 
-if (app) {
-	let event = 'fullscreenchange';
-	if (!app.requestFullscreen && app.webkitRequestFullscreen) {
-		app.requestFullscreen = app.webkitRequestFullscreen;
-		event = 'webkit'+event;
-	}
-	if (app.requestFullscreen) {
-		doc.addEventListener(event, () => {
-			isFullscreen(appFullscreen());
-			$htmlCL.toggle('rl-fullscreen', appFullscreen());
-		});
-	}
-}
-
 dropdownVisibility.subscribe(value => {
 	if (value) {
 		keyScope(ScopeMenu);

dev/Stores/User/Message.js

@@ -1,5 +1,6 @@
 import { Scope } from 'Common/Enums';
-import { elementById, exitFullscreen } from 'Common/Globals';
+import { elementById } from 'Common/Globals';
+import { exitFullscreen } from 'Common/Fullscreen';
 import { addObservablesTo, addSubscribablesTo } from 'External/ko';
 
 import { AppUserStore } from 'Stores/User/App';

dev/View/Popup/Compose.js

@@ -20,7 +20,8 @@ import { messagesDeleteHelper } from 'Common/Folders';
 import { serverRequest } from 'Common/Links';
 import { i18n, getNotification, getUploadErrorDescByCode, timestampToString } from 'Common/Translator';
 import { MessageFlagsCache, setFolderHash } from 'Common/Cache';
-import { Settings, SettingsGet, elementById, addShortcut/*, exitFullscreen, isFullscreen, toggleFullscreen*/ } from 'Common/Globals';
+import { Settings, SettingsGet, elementById, addShortcut } from 'Common/Globals';
+//import { exitFullscreen, isFullscreen, toggleFullscreen } from 'Common/Fullscreen';
 
 import { AppUserStore } from 'Stores/User/App';
 import { SettingsUserStore } from 'Stores/User/Settings';

dev/View/User/MailBox/MessageList.js

@@ -9,13 +9,13 @@ import { UNUSED_OPTION_VALUE } from 'Common/Consts';
 import { doc, leftPanelDisabled, moveAction,
 	Settings, SettingsCapa, SettingsGet,
 	addEventsListeners,
-	addShortcut, registerShortcut, formFieldFocused,
+	addShortcut, registerShortcut, formFieldFocused
-	isFullscreen, toggleFullscreen
 } from 'Common/Globals';
 
 import { computedPaginatorHelper, showMessageComposer, populateMessageBody } from 'Common/UtilsUser';
 import { FileInfo } from 'Common/File';
 import { folderListOptionsBuilder, moveMessagesToFolder } from 'Common/Folders';
+import { isFullscreen, toggleFullscreen } from 'Common/Fullscreen';
 
 import { mailBox, serverRequest } from 'Common/Links';
 import { Selector } from 'Common/Selector';

dev/View/User/MailBox/MessageView.js

@@ -23,12 +23,12 @@ import {
 	SettingsCapa,
 	fireEvent,
 	addShortcut,
-	registerShortcut,
+	registerShortcut
-	isFullscreen, exitFullscreen, toggleFullscreen
 } from 'Common/Globals';
 
 import { arrayLength } from 'Common/Utils';
 import { download, mailToHelper, showMessageComposer } from 'Common/UtilsUser';
+import { isFullscreen, exitFullscreen, toggleFullscreen } from 'Common/Fullscreen';
 
 import { SMAudio } from 'Common/Audio';