From a2aefbf9280f4439ab5f5e4e48a1a94db6a3a665 Mon Sep 17 00:00:00 2001
From: the-djmaze <>
Date: Thu, 21 Jul 2022 12:02:45 +0200
Subject: [PATCH] No need to test '1', empty() is sufficient

---
 .../app/libraries/RainLoop/Providers/Domain.php      | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/snappymail/v/0.0.0/app/libraries/RainLoop/Providers/Domain.php b/snappymail/v/0.0.0/app/libraries/RainLoop/Providers/Domain.php
index 6aa6b7d50..ce647b2a5 100644
--- a/snappymail/v/0.0.0/app/libraries/RainLoop/Providers/Domain.php
+++ b/snappymail/v/0.0.0/app/libraries/RainLoop/Providers/Domain.php
@@ -79,18 +79,18 @@ class Domain extends AbstractProvider
 			$sIncHost = (string) $oActions->GetActionParam('IncHost', '');
 			$iIncPort = (int) $oActions->GetActionParam('IncPort', 143);
 			$iIncSecure = (int) $oActions->GetActionParam('IncSecure', \MailSo\Net\Enumerations\ConnectionSecurityType::NONE);
-			$bIncShortLogin = '1' === (string) $oActions->GetActionParam('IncShortLogin', '0');
-			$bUseSieve = '1' === (string) $oActions->GetActionParam('UseSieve', '0');
+			$bIncShortLogin = !empty($oActions->GetActionParam('IncShortLogin', 0));
+			$bUseSieve = !empty($oActions->GetActionParam('UseSieve', 0));
 			$sSieveHost = (string) $oActions->GetActionParam('SieveHost', '');
 			$iSievePort = (int) $oActions->GetActionParam('SievePort', 4190);
 			$iSieveSecure = (int) $oActions->GetActionParam('SieveSecure', \MailSo\Net\Enumerations\ConnectionSecurityType::NONE);
 			$sOutHost = (string) $oActions->GetActionParam('OutHost', '');
 			$iOutPort = (int) $oActions->GetActionParam('OutPort', 25);
 			$iOutSecure = (int) $oActions->GetActionParam('OutSecure', \MailSo\Net\Enumerations\ConnectionSecurityType::NONE);
-			$bOutShortLogin = '1' === (string) $oActions->GetActionParam('OutShortLogin', '0');
-			$bOutAuth = '1' === (string) $oActions->GetActionParam('OutAuth', '1');
-			$bOutSetSender = '1' === (string) $oActions->GetActionParam('OutSetSender', '0');
-			$bOutUsePhpMail = '1' === (string) $oActions->GetActionParam('OutUsePhpMail', '0');
+			$bOutShortLogin = !empty($oActions->GetActionParam('OutShortLogin', 0));
+			$bOutAuth = !empty($oActions->GetActionParam('OutAuth', 1));
+			$bOutSetSender = !empty($oActions->GetActionParam('OutSetSender', 0));
+			$bOutUsePhpMail = !empty($oActions->GetActionParam('OutUsePhpMail', 0));
 			$sWhiteList = (string) $oActions->GetActionParam('WhiteList', '');
 
 			$oDomain = $sNameForTest ? null : $this->Load($sName);