Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-08-31 13:09:21 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup calls to Knockout observableArray

Browse source 
Improved Knockout observableArray
This commit is contained in:
djmaze 2021-01-22 12:23:20 +01:00
parent fa5476e486
commit b6f0b634fb
47 changed files with 251 additions and 276 deletions
Download patch file Download diff file Expand all files Collapse all files

9
vendors/knockout/src/subscribables/observable.js vendored
View file

@ -24,14 +24,7 @@ ko.observable = initialValue => {
observable[observableLatestValue] = initialValue;
Object.defineProperty(observable, length, {
get: () => length in observable[observableLatestValue] ? observable[observableLatestValue][length] : undefined,
set: function(value) {
if (length in observable[observableLatestValue]) {
this.valueWillMutate();
observable[observableLatestValue][length] = value;
this.valueHasMutated();
}
}
get: () => null == observable[observableLatestValue] ? undefined : observable[observableLatestValue][length]
});
// Inherit from 'subscribable'

6
vendors/knockout/src/subscribables/observableArray.js vendored
View file

@ -57,9 +57,11 @@ Object.setPrototypeOf(ko.observableArray['fn'], ko.observable['fn']);
// Populate ko.observableArray.fn with native arrays functions
Object.getOwnPropertyNames(Array.prototype).forEach(methodName => {
if (typeof Array.prototype[methodName] === 'function') {
if (["pop", "push", "reverse", "shift", "sort", "splice", "unshift"].includes(methodName)) {
// skip property length
if (typeof Array.prototype[methodName] === 'function' && 'constructor' != methodName) {
if (["copyWithin", "fill", "pop", "push", "reverse", "shift", "sort", "splice", "unshift"].includes(methodName)) {
// Mutator methods
// https://developer.mozilla.org/tr/docs/Web/JavaScript/Reference/Global_Objects/Array/prototype#mutator_methods
// Important: Do not add any additional functions here that may reasonably be used to *read* data from the array
// because we'll eval them without causing subscriptions, so ko.computed output could end up getting stale
ko.observableArray['fn'][methodName] = function (...args) {