Resolve #399 (just remove the confusing feature "hide submit button")

This commit is contained in:
the-djmaze 2022-05-17 09:15:06 +02:00
parent cbdb22f1ad
commit c1bed26fd1
30 changed files with 26 additions and 60 deletions

View file

@ -152,7 +152,6 @@ export class AbstractViewSettings
export class AbstractViewLogin extends AbstractView {
constructor(templateID) {
super(templateID, 'Content');
this.hideSubmitButton = SettingsGet('hideSubmitButton');
this.formError = ko.observable(false).extend({ falseTimeout: 500 });
}

View file

@ -4,6 +4,6 @@ export class AdminSettingsLogin extends AbstractViewSettings {
constructor() {
super();
this.addSetting('LoginDefaultDomain');
this.addSettings(['DetermineUserLanguage','DetermineUserDomain','AllowLanguagesOnLogin','hideSubmitButton']);
this.addSettings(['DetermineUserLanguage','DetermineUserDomain','AllowLanguagesOnLogin']);
}
}

View file

@ -696,7 +696,6 @@ class Actions
'LoadingDescription' => $oConfig->Get('webmail', 'loading_description', 'SnappyMail'),
'FaviconUrl' => $oConfig->Get('webmail', 'favicon_url', ''),
'LoginDefaultDomain' => $oConfig->Get('login', 'default_domain', ''),
'hideSubmitButton' => (bool)$oConfig->Get('login', 'hide_submit_button', true),
'DetermineUserLanguage' => (bool)$oConfig->Get('login', 'determine_user_language', true),
'DetermineUserDomain' => (bool)$oConfig->Get('login', 'determine_user_domain', false),
'SieveAllowFileintoInbox' => (bool)$oConfig->Get('labs', 'sieve_allow_fileinto_inbox', false),

View file

@ -78,7 +78,6 @@ class ActionsAdmin extends Actions
$this->setConfigFromParams($oConfig, 'AllowLanguagesOnSettings', 'webmail', 'allow_languages_on_settings', 'bool');
$this->setConfigFromParams($oConfig, 'AllowLanguagesOnLogin', 'login', 'allow_languages_on_login', 'bool');
$this->setConfigFromParams($oConfig, 'hideSubmitButton', 'login', 'hide_submit_button', 'bool');
$this->setConfigFromParams($oConfig, 'AttachmentLimit', 'webmail', 'attachment_size_limit', 'int');
$this->setConfigFromParams($oConfig, 'LoginDefaultDomain', 'login', 'default_domain', 'string');

View file

@ -227,8 +227,6 @@ class Application extends \RainLoop\Config\AbstractConfig
'determine_user_language' => array(true),
'determine_user_domain' => array(false),
'hide_submit_button' => array(false),
'login_lowercase' => array(true),
'sign_me_auto' => array(\RainLoop\Enumerations\SignMeType::DEFAULT_OFF,

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Výchozí doména",
"LABEL_DETERMINE_USER_DOMAIN": "Zkoušet odvodit doménu z uživatelského jména",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Povolit výběr jazyka na přihlašovací obrazovce",
"LABEL_DETERMINE_USER_LANGUAGE": "Zkoušet odvodit jazyk pro uživatele",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Zkoušet odvodit jazyk pro uživatele"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Standard domæne",
"LABEL_DETERMINE_USER_DOMAIN": "Forsøg at bestemme brugerens domæne",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Tillad sprogvalg ved log ind",
"LABEL_DETERMINE_USER_LANGUAGE": "Forsøg at bestemme brugerens sprog",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Forsøg at bestemme brugerens sprog"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Standarddomain",
"LABEL_DETERMINE_USER_DOMAIN": "Versuche Domain des Benutzers zu ermitteln",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Sprachauswahl bei der Anmeldung zulassen",
"LABEL_DETERMINE_USER_LANGUAGE": "Versuche Sprache des Benutzers zu ermitteln",
"LABEL_HIDE_SUBMIT_BUTTON": "Die Schaltfläche 'Anmelden' ausblenden"
"LABEL_DETERMINE_USER_LANGUAGE": "Versuche Sprache des Benutzers zu ermitteln"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Default Domain",
"LABEL_DETERMINE_USER_DOMAIN": "Try to determine user domain",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Allow language selection on login screen",
"LABEL_DETERMINE_USER_LANGUAGE": "Try to determine user language",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Try to determine user language"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Dominio por defecto",
"LABEL_DETERMINE_USER_DOMAIN": "Intentar encontrar el dominio del usuario",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Permitir la selección de idioma en la pantalla de ingreso",
"LABEL_DETERMINE_USER_LANGUAGE": "Intentar definir el idioma del usuari",
"LABEL_HIDE_SUBMIT_BUTTON": "Ocultar el botón 'Acceder'"
"LABEL_DETERMINE_USER_LANGUAGE": "Intentar definir el idioma del usuari"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Personalización",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "دامنه پیش‌فرض",
"LABEL_DETERMINE_USER_DOMAIN": "برای تشخیص دامنه کاربر تلاش شود",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "انتخاب زبان در صفحه ورود",
"LABEL_DETERMINE_USER_LANGUAGE": "برای تشخیص زبان کاربر تلاش شود",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "برای تشخیص زبان کاربر تلاش شود"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "برندسازی",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Oletus domain",
"LABEL_DETERMINE_USER_DOMAIN": "Koita päätellä käyttäjän domain",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Salli kielivalinta kirjautumissivulla",
"LABEL_DETERMINE_USER_LANGUAGE": "Koita päätellä käyttäjän kieli",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Koita päätellä käyttäjän kieli"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Brändäys",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Domaine par défaut",
"LABEL_DETERMINE_USER_DOMAIN": "Deviner le domaine de l'utilisateur",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Permettre la sélection de la langue sur l'écran de connexion",
"LABEL_DETERMINE_USER_LANGUAGE": "Deviner la langue de l'utilisateur",
"LABEL_HIDE_SUBMIT_BUTTON": "Masquer le bouton 'Se connecter'"
"LABEL_DETERMINE_USER_LANGUAGE": "Deviner la langue de l'utilisateur"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Logo & Marque",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Alapértelmezett domain",
"LABEL_DETERMINE_USER_DOMAIN": "Próbálja megállapítani a felhasználó domainjét",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Nyel választás engedélyezése a bejelentkező képernyőn",
"LABEL_DETERMINE_USER_LANGUAGE": "Próbálja megállapítani a felhasználó nyelvét",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Próbálja megállapítani a felhasználó nyelvét"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Arculat",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Domain bawaan",
"LABEL_DETERMINE_USER_DOMAIN": "Coba untuk memeriksa user domain",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Izinkan pemilihan bahasa di laman login",
"LABEL_DETERMINE_USER_LANGUAGE": "Coba untuk memeriksa bahasa user",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Coba untuk memeriksa bahasa user"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Default Domain",
"LABEL_DETERMINE_USER_DOMAIN": "Try to determine user domain",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Allow language selection on login screen",
"LABEL_DETERMINE_USER_LANGUAGE": "Try to determine user language",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Try to determine user language"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "デフォルトドメイン",
"LABEL_DETERMINE_USER_DOMAIN": "ユーザードメインを自動で選ぶ",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "ログイン画面で言語選択を使用する",
"LABEL_DETERMINE_USER_LANGUAGE": "ユーザー言語を自動で選ぶ",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "ユーザー言語を自動で選ぶ"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "ブランド化",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Numatytasis Domenas",
"LABEL_DETERMINE_USER_DOMAIN": "Bandyti nuspėti vartotojo domeną",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Leisti kalbų keitimą prisijungimo lange",
"LABEL_DETERMINE_USER_LANGUAGE": "bandyti nuspėti vartotojo kalbą",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "bandyti nuspėti vartotojo kalbą"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Prekės ženklo derinimas",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Standard-domene",
"LABEL_DETERMINE_USER_DOMAIN": "Prøv å finne brukerens domene",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "La brukere velge språk på innloggingsskjerm",
"LABEL_DETERMINE_USER_LANGUAGE": "Prøv å finne brukerens språk",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Prøv å finne brukerens språk"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Utforming",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Standaard domein",
"LABEL_DETERMINE_USER_DOMAIN": "Probeer gebruikersdomein te bepalen",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Sta taal selectie toe in het login scherm",
"LABEL_DETERMINE_USER_LANGUAGE": "Probeer gebruiker taal te bepalen",
"LABEL_HIDE_SUBMIT_BUTTON": "Verberg de 'Aanmelden' knop"
"LABEL_DETERMINE_USER_LANGUAGE": "Probeer gebruiker taal te bepalen"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Huisstijl",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Domyślna domena",
"LABEL_DETERMINE_USER_DOMAIN": "Spróbuj określić domenę użytkownika",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Zezwól na zmianę języka na ekranie logowania",
"LABEL_DETERMINE_USER_LANGUAGE": "Spróbuj określić język użytkownika",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Spróbuj określić język użytkownika"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Personalizacja",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Domínio padrão",
"LABEL_DETERMINE_USER_DOMAIN": "Tentar determinar o domínio do usuário",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Permitir escolha do idioma na tela de entrada",
"LABEL_DETERMINE_USER_LANGUAGE": "Tentar determinar o idioma do usuário",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Tentar determinar o idioma do usuário"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Personalização",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Основной домен",
"LABEL_DETERMINE_USER_DOMAIN": "Пытаться определить домен пользователя",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Разрешить выбор языка на странице входа",
"LABEL_DETERMINE_USER_LANGUAGE": "Пытаться определить язык пользователя",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Пытаться определить язык пользователя"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Брендинг",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Predvolená doména",
"LABEL_DETERMINE_USER_DOMAIN": "Pokúsiť sa určiť doménu používateľa",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Povoliť výber jazyka na prihlasovacej obrazovke",
"LABEL_DETERMINE_USER_LANGUAGE": "Pokúsiť sa určiť používateľov jazyk",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Pokúsiť sa určiť používateľov jazyk"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Vlastné označenie",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Privzeta domena",
"LABEL_DETERMINE_USER_DOMAIN": "Poskusi ugotoviti domeno uporabnika",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Dovoli izbor jezika na prijavnem zaslonu",
"LABEL_DETERMINE_USER_LANGUAGE": "Poskusi ugotoviti jezik uporabnika",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Poskusi ugotoviti jezik uporabnika"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Prilagoditev",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "Standarddomän",
"LABEL_DETERMINE_USER_DOMAIN": "Försök att bestämma användardomän",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "Tillåt språkändringar på inloggningsskärmen",
"LABEL_DETERMINE_USER_LANGUAGE": "Försök att bestämma användarens språk",
"LABEL_HIDE_SUBMIT_BUTTON": "Hide the 'Sign In' button"
"LABEL_DETERMINE_USER_LANGUAGE": "Försök att bestämma användarens språk"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Branding",

View file

@ -49,8 +49,7 @@
"LABEL_DEFAULT_DOMAIN": "默认域名",
"LABEL_DETERMINE_USER_DOMAIN": "尝试判断用户使用的域名",
"LABEL_ALLOW_LANGUAGES_ON_LOGIN": "允许在登录界面选择语言",
"LABEL_DETERMINE_USER_LANGUAGE": "尝试判断用户使用语言",
"LABEL_HIDE_SUBMIT_BUTTON": "隐藏“登录”按钮"
"LABEL_DETERMINE_USER_LANGUAGE": "尝试判断用户使用语言"
},
"TAB_BRANDING": {
"LEGEND_BRANDING": "Logo",

View file

@ -23,10 +23,9 @@
autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"
data-bind="textInput: totp, disable: submitRequest"
data-i18n="[placeholder]LOGIN/LABEL_TOTP">
<button class="fontastic" data-bind="command: submitCommand" data-i18n="[title]LOGIN/BUTTON_LOGIN"></button>
</div>
<div id="plugin-Login-BottomControlGroup"></div>
<div class="controls" data-bind="hidden: hideSubmitButton">
<div class="controls">
<button class="btn btn-large btn-block"
data-bind="command: submitCommand"
data-i18n="LOGIN/BUTTON_LOGIN"></button>

View file

@ -26,11 +26,6 @@
name: 'Checkbox',
params: { enable: allowLanguagesOnLogin, value: determineUserLanguage, label: 'TAB_LOGIN/LABEL_DETERMINE_USER_LANGUAGE' }
}"></div>
<br>
<div data-bind="component: {
name: 'Checkbox',
params: { value: hideSubmitButton, label: 'TAB_LOGIN/LABEL_HIDE_SUBMIT_BUTTON' }
}"></div>
</div>
</div>
</div>

View file

@ -22,10 +22,9 @@
autocomplete="current-password" autocorrect="off" autocapitalize="off" spellcheck="false"
data-bind="textInput: password, disable: submitRequest"
data-i18n="[placeholder]GLOBAL/PASSWORD">
<button class="fontastic" data-bind="command: submitCommand, visible: '' !== password()" data-i18n="[title]LOGIN/BUTTON_SIGN_IN"></button>
</div>
<div id="plugin-Login-BottomControlGroup"></div>
<div class="controls" data-bind="hidden: hideSubmitButton">
<div class="controls">
<button class="btn btn-large btn-block buttonLogin"
data-bind="command: submitCommand"
data-i18n="LOGIN/BUTTON_SIGN_IN"></button>
@ -39,7 +38,7 @@
}
}"></div>
<div class="language-buttons">
<a href="#" tabindex="-1" class="language-button fontastic"
<a href="#" class="language-button fontastic"
data-bind="visible: allowLanguagesOnLogin, click: selectLanguage, css: { 'icon-spinner' : langRequest }"
data-i18n="[title]POPUPS_LANGUAGES/TITLE_LANGUAGES">
🌍