Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-07-13 03:27:39 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prevent memory leaks in *Model

Browse source
This commit is contained in:
djmaze 2020-10-25 11:46:58 +01:00
parent 48a9a03762
commit d7a4639d6b
22 changed files with 221 additions and 225 deletions
Download patch file Download diff file Expand all files Collapse all files

48
dev/Knoin/AbstractModel.js
View file

@ -5,50 +5,52 @@ function disposeOne(disposable) {
}
}
function typeCast(current, value) {
switch (typeof current)
function typeCast(curValue, newValue) {
switch (typeof curValue)
{
case 'boolean': return !!value;
case 'number': return isFinite(value) ? parseFloat(value) : 0;
case 'string': return null != value ? '' + value : '';
case 'boolean': return !!newValue;
case 'number': return isFinite(newValue) ? parseFloat(newValue) : 0;
case 'string': return null != newValue ? '' + newValue : '';
case 'object':
if (current.constructor.reviveFromJson) {
return current.constructor.reviveFromJson(value) || undefined;
if (curValue.constructor.reviveFromJson) {
return curValue.constructor.reviveFromJson(newValue) || undefined;
}
if (!Array.isArray(current) || !Array.isArray(value))
if (!Array.isArray(curValue) || !Array.isArray(newValue))
return undefined;
}
return value;
return newValue;
}
export class AbstractModel {
disposables = [];
/**
* @param {string} modelName = ''
*/
constructor() {
/*
if (new.target === AbstractModel) {
throw new Error("Can't instantiate AbstractModel!");
}
this.sModelName = new.target.name;
*/
}
regDisposables(value) {
if (Array.isArray(value)) {
value.forEach(item => this.disposables.push(item));
} else if (value) {
this.disposables.push(value);
}
addObservables(obj) {
Object.entries(obj).forEach(([key, value]) => this[key] = ko.observable(value) );
/*
Object.entries(obj).forEach(([key, value]) =>
this[key] = Array.isArray(value) ? ko.observableArray(value) : ko.observable(value)
);
*/
}
addSubscribables(obj) {
Object.entries(obj).forEach(([key, fn]) => this.disposables.push( this[key].subscribe(fn) ) );
}
onDestroy() {
if (Array.isArray(this.disposables)) {
this.disposables.forEach(disposeOne);
}
Object.values(this).forEach(disposeOne);
this.disposables.forEach(disposeOne);
Object.entries(this).forEach(([key, value]) => {
disposeOne(value);
this[key] = null;
});
}
/**