Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-09-02 05:59:21 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Prevent memory leaks in *Model

Browse source
This commit is contained in:
djmaze 2020-10-25 11:46:58 +01:00
parent 48a9a03762
commit d7a4639d6b
22 changed files with 221 additions and 225 deletions
Download patch file Download diff file Expand all files Collapse all files

28
dev/Model/FilterCondition.js
View file

@ -8,13 +8,15 @@ class FilterConditionModel extends AbstractModel {
constructor() {
super();
this.field = ko.observable(FilterConditionField.From);
this.type = ko.observable(FilterConditionType.Contains);
this.value = ko.observable('');
this.value.error = ko.observable(false);
this.addObservables({
field: FilterConditionField.From,
type: FilterConditionType.Contains,
value: '',
valueError: false,
this.valueSecond = ko.observable('');
this.valueSecond.error = ko.observable(false);
valueSecond: '',
valueSecondError: false
});
this.template = ko.computed(() => {
let template = '';
@ -33,22 +35,22 @@ class FilterConditionModel extends AbstractModel {
return template;
}, this);
this.field.subscribe(() => {
this.value('');
this.valueSecond('');
this.addSubscribables({
field: () => {
this.value('');
this.valueSecond('');
}
});
this.regDisposables([this.template]);
}
verify() {
if (!this.value()) {
this.value.error(true);
this.valueError(true);
return false;
}
if (FilterConditionField.Header === this.field() && !this.valueSecond()) {
this.valueSecond.error(true);
this.valueSecondError(true);
return false;
}