From ddb95b925d954d364a874345d64681afda592b8d Mon Sep 17 00:00:00 2001
From: the-djmaze <>
Date: Tue, 17 May 2022 16:53:32 +0200
Subject: [PATCH] Sieve Scripts use radio buttons to prevent confusion

---
 dev/Settings/User/Filters.js                       |  2 +-
 .../app/templates/Views/User/SettingsFilters.html  | 14 +++++---------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/dev/Settings/User/Filters.js b/dev/Settings/User/Filters.js
index 7010603bc..dd2e1bf63 100644
--- a/dev/Settings/User/Filters.js
+++ b/dev/Settings/User/Filters.js
@@ -43,7 +43,7 @@ export class UserSettingsFilters /*extends AbstractViewSettings*/ {
 
 	onBuild(oDom) {
 		oDom.addEventListener('click', event => {
-			const el = event.target.closestWithin('.script-item .e-action', oDom),
+			const el = event.target.closestWithin('.script-item .script-name', oDom),
 				script = el && ko.dataFor(el);
 			script && this.editScript(script);
 		});
diff --git a/snappymail/v/0.0.0/app/templates/Views/User/SettingsFilters.html b/snappymail/v/0.0.0/app/templates/Views/User/SettingsFilters.html
index 5c3fa90cd..122a82472 100644
--- a/snappymail/v/0.0.0/app/templates/Views/User/SettingsFilters.html
+++ b/snappymail/v/0.0.0/app/templates/Views/User/SettingsFilters.html
@@ -17,10 +17,8 @@
 		<!-- ko if: allowFilters() -->
 		<tr><th colspan="4" data-i18n="SETTINGS_FILTERS/SIMPLE"></th></tr>
 		<tr class="script-item">
-			<td>
-				<span class="fontastic" data-bind="click: function (oScript) { $root.toggleScript(oScript); }, text: active() ? '☑' : '☐'"></span>
-			</td>
-			<td class="e-action" class="script-name" data-bind="text: name()"></td>
+			<td class="e-action fontastic" data-bind="click: function (oScript) { $root.toggleScript(oScript); }, text: active() ? '⦿' : '○'"></td>
+			<td class="e-action script-name" data-bind="text: name()"></td>
 			<td></td>
 			<td></td>
 		</tr>
@@ -28,16 +26,14 @@
 		<!-- /ko -->
 		<!-- ko if: !allowFilters() -->
 		<tr class="script-item">
-			<td>
-				<span class="fontastic" data-bind="click: function (oScript) { $root.toggleScript(oScript); }, text: active() ? '☑' : '☐'"></span>
-			</td>
-			<td class="e-action" class="script-name" data-bind="text: name()"></td>
+			<td class="e-action fontastic" data-bind="click: function (oScript) { $root.toggleScript(oScript); }, text: active() ? '⦿' : '○'"></td>
+			<td class="e-action script-name" data-bind="text: name()"></td>
 			<td>
 				<a class="btn btn-small btn-danger button-confirm-delete" data-bind="css: {'delete-access': askDelete()}, click: function(oScript) { $root.deleteScript(oScript); }"
 					data-i18n="GLOBAL/ARE_YOU_SURE"></a>
 			</td>
 			<td>
-				<span class="delete-script fontastic" data-bind="visible: !askDelete() && canBeDeleted(), click: function (oScript) { $root.scriptForDeletion(oScript); }">🗑</span>
+				<span class="e-action fontastic" data-bind="visible: !askDelete() && canBeDeleted(), click: function (oScript) { $root.scriptForDeletion(oScript); }">🗑</span>
 			</td>
 		</tr>
 		<!-- /ko -->