From df8f13e3590df70a15ed024cd0ed7af6af217703 Mon Sep 17 00:00:00 2001
From: the-djmaze <>
Date: Sun, 3 Mar 2024 16:48:42 +0100
Subject: [PATCH] KnockoutJS drop unused `bindingRewriteValidators`

---
 .../knockout/src/binding/defaultBindings/foreach.js  |  1 -
 .../src/binding/defaultBindings/ifIfnotWith.js       |  1 -
 vendors/knockout/src/binding/expressionRewriting.js  |  2 --
 vendors/knockout/src/templating/templating.js        | 12 ------------
 4 files changed, 16 deletions(-)

diff --git a/vendors/knockout/src/binding/defaultBindings/foreach.js b/vendors/knockout/src/binding/defaultBindings/foreach.js
index a1c5f25a8..1e8879a29 100644
--- a/vendors/knockout/src/binding/defaultBindings/foreach.js
+++ b/vendors/knockout/src/binding/defaultBindings/foreach.js
@@ -25,5 +25,4 @@ ko.bindingHandlers['foreach'] = {
     'update': (element, valueAccessor, allBindings, viewModel, bindingContext) =>
         ko.bindingHandlers['template']['update'](element, ko.bindingHandlers['foreach'].makeTemplateValueAccessor(valueAccessor), allBindings, viewModel, bindingContext)
 };
-ko.expressionRewriting.bindingRewriteValidators['foreach'] = false; // Can't rewrite control flow bindings
 ko.virtualElements.allowedBindings['foreach'] = true;
diff --git a/vendors/knockout/src/binding/defaultBindings/ifIfnotWith.js b/vendors/knockout/src/binding/defaultBindings/ifIfnotWith.js
index b5e01407f..c124b250e 100644
--- a/vendors/knockout/src/binding/defaultBindings/ifIfnotWith.js
+++ b/vendors/knockout/src/binding/defaultBindings/ifIfnotWith.js
@@ -53,7 +53,6 @@ function makeWithIfBinding(bindingKey, isWith, isNot) {
             return { 'controlsDescendantBindings': true };
         }
     };
-    ko.expressionRewriting.bindingRewriteValidators[bindingKey] = false; // Can't rewrite control flow bindings
     ko.virtualElements.allowedBindings[bindingKey] = true;
 }
 
diff --git a/vendors/knockout/src/binding/expressionRewriting.js b/vendors/knockout/src/binding/expressionRewriting.js
index 90d23d5ea..4fd08f404 100644
--- a/vendors/knockout/src/binding/expressionRewriting.js
+++ b/vendors/knockout/src/binding/expressionRewriting.js
@@ -148,8 +148,6 @@ ko.expressionRewriting = (() => {
         };
 
     return {
-        bindingRewriteValidators: [],
-
 //        twoWayBindings: twoWayBindings,
 
         parseObjectLiteral: parseObjectLiteral,
diff --git a/vendors/knockout/src/templating/templating.js b/vendors/knockout/src/templating/templating.js
index 825353f15..e394b42fb 100644
--- a/vendors/knockout/src/templating/templating.js
+++ b/vendors/knockout/src/templating/templating.js
@@ -259,17 +259,5 @@
         }
     };
 
-    // Anonymous templates can't be rewritten. Give a nice error message if you try to do it.
-    ko.expressionRewriting.bindingRewriteValidators['template'] = bindingValue => {
-        var parsedBindingValue = ko.expressionRewriting.parseObjectLiteral(bindingValue);
-
-        if ((parsedBindingValue.length == 1) && parsedBindingValue[0]['unknown'])
-            return null; // It looks like a string literal, not an object literal, so treat it as a named template (which is allowed for rewriting)
-
-        if (ko.expressionRewriting.keyValueArrayContainsKey(parsedBindingValue, "name"))
-            return null; // Named templates can be rewritten, so return "no error"
-        return "This template engine does not support anonymous templates nested within its templates";
-    };
-
     ko.virtualElements.allowedBindings['template'] = true;
 })();