Changed: MailSo\*Collection now extends \ArrayObject

Changed: fixed __constructor param type hinting
Replace: &$o with $o as objects don't need & referencing
This commit is contained in:
djmaze 2020-03-18 23:14:00 +01:00
parent 9bb44e7f98
commit f6fdb69c65
30 changed files with 290 additions and 736 deletions

View file

@ -23,7 +23,7 @@ class File extends \MailSo\Log\Driver
*/
private $sLoggerFileName;
protected function __construct($sLoggerFileName, $sNewLine = "\r\n")
protected function __construct(string $sLoggerFileName, string $sNewLine = "\r\n")
{
parent::__construct();

View file

@ -23,7 +23,7 @@ class Inline extends \MailSo\Log\Driver
*/
private $bHtmlEncodeSpecialChars;
protected function __construct($sNewLine = "\r\n", $bHtmlEncodeSpecialChars = false)
protected function __construct(string $sNewLine = "\r\n", bool $bHtmlEncodeSpecialChars = false)
{
parent::__construct();

View file

@ -42,7 +42,7 @@ class Logger extends \MailSo\Base\Collection
*/
private $bHideErrorNotices;
protected function __construct($bRegPhpErrorHandler = true)
protected function __construct(bool $bRegPhpErrorHandler = true)
{
parent::__construct();
@ -208,10 +208,9 @@ class Logger extends \MailSo\Base\Collection
{
$iResult = 1;
$aLoggers =& $this->GetAsArray();
foreach ($aLoggers as /* @var $oLogger \MailSo\Log\Driver */ &$oLogger)
foreach ($this as /* @var $oLogger \MailSo\Log\Driver */ $oLogger)
{
$iResult &= $oLogger->WriteEmptyLine();
$iResult = $oLogger->WriteEmptyLine();
}
return (bool) $iResult;
@ -236,10 +235,9 @@ class Logger extends \MailSo\Base\Collection
$sDesc = \str_replace($this->aSecretWords, '*******', $sDesc);
}
$aLoggers =& $this->GetAsArray();
foreach ($aLoggers as /* @var $oLogger \MailSo\Log\Driver */ $oLogger)
foreach ($this as /* @var $oLogger \MailSo\Log\Driver */ $oLogger)
{
$iResult &= $oLogger->Write($sDesc, $iType, $sName, $bDiplayCrLf);
$iResult = $oLogger->Write($sDesc, $iType, $sName, $bDiplayCrLf);
}
return (bool) $iResult;