Dereku/snappymail
1
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-08-27 19:19:21 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleanup Squire and Knockout with help of Chromium Code Coverage

Browse source 
Bugfix: Squire inlineNodeNames the 'I' tag was missing
Improved: Squire style editing
This commit is contained in:
djmaze 2021-02-23 22:50:48 +01:00
parent 0158a5fe1e
commit fac36e828b
9 changed files with 2820 additions and 3034 deletions
Download patch file Download diff file Expand all files Collapse all files

23
dev/View/Popup/Contacts.js
View file

@ -72,22 +72,6 @@ class ContactsPopupView extends AbstractViewPopup {
this.viewProperties = ko.observableArray();
/*
// Somehow this is broken now when calling addNewProperty
const fFastClearEmptyListHelper = list => {
if (list && list.length) {
this.viewProperties.removeAll(list);
delegateRunOnDestroy(list);
}
};
this.addSubscribables({
viewPropertiesEmailsEmptyAndOnFocused: fFastClearEmptyListHelper,
viewPropertiesPhonesEmptyAndOnFocused: fFastClearEmptyListHelper,
viewPropertiesWebEmptyAndOnFocused: fFastClearEmptyListHelper,
viewPropertiesOtherEmptyAndOnFocused: fFastClearEmptyListHelper
});
*/
this.useCheckboxesInList = SettingsStore.useCheckboxesInList;
this.selector = new Selector(
@ -135,12 +119,7 @@ class ContactsPopupView extends AbstractViewPopup {
viewPropertiesPhones: () => this.viewProperties.filter(property => property.isType(ContactPropertyType.Phone)),
contactHasValidName: () => !!this.viewProperties.find(prop => propertyIsName(prop) && prop.isValid()),
/*
viewPropertiesEmailsEmptyAndOnFocused: () => this.viewPropertiesEmails().filter(propertyFocused),
viewPropertiesPhonesEmptyAndOnFocused: () => this.viewPropertiesPhones().filter(propertyFocused),
viewPropertiesWebEmptyAndOnFocused: () => this.viewPropertiesWeb().filter(propertyFocused),
viewPropertiesOtherEmptyAndOnFocused: () => this.viewPropertiesOther().filter(propertyFocused),
*/
contactsCheckedOrSelected: () => {
const checked = this.contacts.filter(item => item.checked && item.checked()),
selected = this.currentContact();