Commit graph

44 commits

Author SHA1 Message Date
the-djmaze
3776ac6b32 @ZaphodB fix(security): S/MIME verify reported altered messages as validly signed
OpenSSL::verify() called openssl_pkcs7_verify with PKCS7_NOSIGS, which skips
the signature check, and returned success whenever that call did. Any
well-formed signed message therefore came back as success: true, including one
whose content had been changed after signing, and the client shows that as a
good signature (Message.js smimeSigned). Applies to the message view, the
explicit verify action and signed content inside decrypted mail.

The call is also how the content of an opaque signed message is extracted for
display, so it stays as it is for that, and a second openssl_pkcs7_verify
without PKCS7_NOSIGS now decides success and does not throw on failure. A
message with a broken signature remains readable but is no longer reported as
signed. PKCS7_NOVERIFY is kept on purpose: the signer certificate is not checked
against a CA, so success means the content is what the certificate holder
signed, not that the certificate is trusted; the comment says so.

test/smime-verify.php signs detached and opaque messages with a throwaway key,
checks the intact ones verify, and that altering one byte of signed content
flips success to false while the content stays readable. Before this change
the altered detached message was reported as validly signed.
2026-10-24 11:57:38 +02:00
the-djmaze
0263f8fe09 Use the custom Squire as submodule vendors/squire2 2024-09-17 15:00:28 +02:00
the-djmaze
c21817e5e0 v2.25.1 2023-01-30 15:49:58 +01:00
kouinkouin
305cade97b
chore(git): ignore *.zip resulted from release.php 2022-05-13 15:30:53 +02:00
the-djmaze
e28c5bdbb6 Drop some unused Node.js code and be es2020 2022-01-31 10:18:51 +01:00
djmaze
1904ecf7d9 v2.8.0 2021-10-29 13:09:12 +02:00
djmaze
51958babba v2.2.0 2021-01-22 17:41:46 +01:00
Floris Westerman
b301feee2f
Update gitignore 2020-11-26 15:14:51 +01:00
Floris Westerman
fcf2c2468d
Add better Docker development and prod support 2020-11-26 15:14:51 +01:00
Floris Westerman
1c63287243
Fixed some bugs 2020-11-09 21:46:22 +01:00
djmaze
d0f686c657 Rename basefolder 'rainloop' to 'snappymail'
this prevents conflicts with original rainloop
2020-10-15 16:21:52 +02:00
RainLoop Team
450528ff00 Add prettier 2019-07-04 22:09:27 +03:00
RainLoop Team
35ef89c2a6 Optimize building process 2018-03-30 00:43:46 +03:00
RainLoop
866b0ddc6d Add docker support for development. 2018-02-27 02:13:53 +03:00
RainLoop
33a9234d9c 1.11.2 2017-09-19 23:16:22 +03:00
RainLoop Team
f8b4aa8683 Update package.json dependencies (+ fixes and improvements) 2017-03-12 20:44:42 +03:00
RainLoop Team
e5af98b04b Update ckeditor
Move e2e tests
Code refactoring
2016-09-12 23:50:21 +03:00
RainLoop Team
9993432c7b Add e2e tests 2016-09-11 01:11:08 +03:00
RainLoop Team
1526130bfc Add asserts folder
Add @command decorator
2016-09-03 02:19:37 +03:00
RainLoop Team
a60ffc06e1 Update ckeditor
Avoid empty commands
Small fixes
2016-09-01 23:41:36 +03:00
RainLoop Team
17669b7be0 es5 -> es2015 (last stage)
Signature plugin fixes
Add view decorator
A large number of fixes
2016-08-20 20:30:16 +03:00
RainLoop Team
5bf5a96b08 Fix localization/moment folder 2016-08-09 19:36:31 +03:00
RainLoop Team
2c68f039ae Remove unnecessary code 2016-07-02 21:08:49 +03:00
RainLoop Team
90d95d3ca4 Code refactoring 2016-06-16 02:36:44 +03:00
RainLoop Team
2ed88f5d27 Simple PHPUnit tests 2016-05-20 22:02:39 +03:00
RainLoop Team
5663f8b1bb Add tests (first try) 2016-05-07 15:39:44 +03:00
RainLoop Team
9cc68ef2b1 Added ckeditor to gitignore 2015-10-19 23:08:51 +04:00
RainLoop Team
d5bafd8f9b Small fixes 2015-10-19 21:53:15 +04:00
Zaffke
ef5231decd Modified the postfixadmin-change-password plugin to give users these additional options for MySQL:
* Specify the table name
* Specify the column name for user names
* Specify the column name for the passwords
2015-08-13 15:46:38 -05:00
RainLoop Team
c99a46a118 Small improvements 2015-07-30 01:14:48 +04:00
RainLoop Team
f91f74fe7c Release fixes 2015-05-12 20:33:02 +04:00
RainLoop Team
104ac0806a Source refactoring 2015-05-04 20:52:24 +04:00
RainLoop Team
abddb3d828 Pre release fixes and improvements 2015-02-01 19:44:44 +04:00
RainLoop Team
e4b286e257 Merged from sub repository (filters - step 4) 2014-12-18 01:02:29 +04:00
RainLoop Team
af43329902 .gitignore change 2014-09-05 03:24:31 +04:00
RainLoop Team
fb18e4e799 ownCloud new package (with built-in RainLoop Webmail)
Remove VERSION file dependence.
Small fixes
2014-05-30 05:42:22 +04:00
RainLoop Team
c8a5d45f37 Folder unread count view fix.
Add MailSo HtmlUtils ClearHtmlSimple function
2013-12-16 19:43:04 +04:00
RainLoop Team
388a688d9d Add plugin build script (ANT).
Webmail bilder script fix.
2013-12-07 03:38:49 +04:00
RainLoop Team
e673405dbe IspManager Plugin small changes 2013-12-02 20:52:19 +04:00
RainLoop Team
67e6084276 Add build task in Grunt script.
Minor fixes
2013-11-17 02:02:13 +04:00
RainLoop Team
ea4262e954 improved render of complex HTML mails. 2013-11-16 04:04:07 +04:00
RainLoop Team
8b09b84e7c .gitignore fix 2013-11-16 02:42:23 +04:00
RainLoop Team
f9e764c411 fix VERSION file in data folder 2013-11-16 02:32:58 +04:00
RainLoop Team
4cc2207513 Uploading and preparing the repository to the dev version.
Original unminified source code (dev folder - js, css, less) (fixes #6)
Grunt build system
Multiple identities correction (fixes #9)
Compose html editor (fixes #12)
New general settings - Loading Description
New warning about default admin password
Split general and login screen settings
2013-11-16 02:21:12 +04:00