Dereku/snappymail
0
0
Fork 0
mirror of https://github.com/the-djmaze/snappymail.git synced 2026-10-24 22:25:09 +03:00
Code Issues Projects Releases Packages Wiki Activity Actions
No description
7185 commits 10 branches 204 tags 82 MiB
Find a file
Fathi Ben Nasr 279cc6406e PdoAddressBook: GetContactByEmail() passed the wrong columns 
GetContactByEmail() runs

    SELECT DISTINCT id_contact FROM rainloop_ab_properties WHERE ...

and hands the statement to getContactsFromPDO(), which unconditionally reads
id_contact_str, changed, etag and jcard from every row. None of those are
selected, so every match raises three PHP warnings:

    Undefined array key "id_contact_str"
    Undefined array key "changed"
    Undefined array key "etag"

and the Contact that comes back carries IdContactStr '' with Changed and Etag
both 0 -- values a CardDAV sync would use.

The lookup itself still works: with no jcard column either, every row falls
into the follow-up properties query, so the contact data is right and only the
metadata is wrong. That is what makes it easy to miss.

It is not rare. The avatars plugin calls GetContactByEmail() for the sender of
a message, so a mailbox view triggers it repeatedly -- 23 warnings in a single
session on one of our installs.

Fix: look the contact up by id instead. GetContactByID() already selects the
columns getContactsFromPDO() expects, so the Contact comes back complete, and
the search query keeps doing what it is good at -- finding the id. The unused
$oContact and $iIdContact locals go with it.

Verified against a real PDO: the current query returns one column and the
reader warns on id_contact_str; the replacement returns all of them, warns
nothing, and yields the real IdContactStr and changed instead of '' and 0.

Note: this layer has no test suite upstream, so the verification is a
standalone reproduction rather than an added test.
2026-09-05 03:37:09 +00:00
.docker fix spacing 2024-09-22 19:02:57 +02:00
.github Small change to report bug template 2024-05-28 16:43:49 +02:00
build Small change for #1350 2023-12-11 11:07:10 +01:00
cli Drop application.ini for Docker #965 2023-11-21 21:10:33 +01:00
data Added README to /data/ folder 2020-11-03 16:22:26 +01:00
dev Small change for #1948 to make it relative to font size 2025-06-16 17:21:26 +02:00
examples Moved cache drivers outside core to extensions (plugins) 2024-03-22 04:03:39 +01:00
fail2ban Bugfix: wrong fail2ban instruction 2021-03-23 22:04:27 +01:00
integrations Ommit Nextcloud "max-version" as it is optional 2026-03-11 17:56:44 +01:00
plugins Bump version for #1918 2025-03-10 16:35:27 +01:00
public_html Improved translator a bit 2024-03-26 23:30:58 +01:00
snappymail/v/0.0.0 PdoAddressBook: GetContactByEmail() passed the wrong columns 2026-09-05 03:37:09 +00:00
tasks Use the custom Squire as submodule vendors/squire2 2024-09-17 15:00:28 +02:00
test Resolve #695 2022-11-23 16:26:26 +01:00
vendors Cleanup KnockoutJS a bit 2024-10-30 01:08:18 +01:00
.browserslistrc Bump supported browserlist to cleanup CSS 2020-07-30 12:23:11 +02:00
.cmds Add github action 2021-01-16 17:51:14 +03:00
.dockerignore Enhancement: Add Docker Hub image (#965) 2023-11-20 15:01:26 +01:00
.editorconfig Fixing indentation 2020-11-10 11:52:21 +01:00
.eslintignore Add prettier 2019-07-04 22:09:27 +03:00
.eslintrc.js Added markedjs for #1604 2024-08-25 18:04:59 +02:00
.gitignore Use the custom Squire as submodule vendors/squire2 2024-09-17 15:00:28 +02:00
.gitmodules Use the custom Squire as submodule vendors/squire2 2024-09-17 15:00:28 +02:00
.htaccess https://github.com/the-djmaze/snappymail/issues/1645#issuecomment-2202364675 2024-07-02 13:18:52 +02:00
.prettierignore Add prettier 2019-07-04 22:09:27 +03:00
.prettierrc Add prettier 2019-07-04 22:09:27 +03:00
_include.php Move brotli and gzip compress option to application.ini 2023-02-23 08:39:40 +01:00
CHANGELOG.md v2.38.2 2024-10-09 21:41:01 +02:00
CODE_OF_CONDUCT.md Updated Code of Conduct 2020-09-24 20:04:31 +02:00
CONTRIBUTING.md Resolve #891 and other index cache issues 2023-02-03 09:20:42 +01:00
docker-compose.yml Fix (development): Fix self-signed certs verification in docker-compose.yml 2023-11-24 10:47:32 +00:00
gulpfile.js Move "assets" to proper location in snappymail/v/0.0.0/static/ 2023-02-02 17:19:06 +01:00
index.php Force PHP opcache_invalidate due to upgrade error reports "Missing version directory" 2022-11-01 10:14:33 +01:00
jsconfig.json Rename basefolder 'rainloop' to 'snappymail' 2020-10-15 16:21:52 +02:00
LICENSE Revert RainLoop merge that caused MIT vs AGPL 2022-09-01 21:16:52 +02:00
Makefile Road to the MIT 2022-08-31 19:20:47 +00:00
package.json v2.38.2 2024-10-09 21:41:01 +02:00
README.md v2.38.2 2024-10-09 21:41:01 +02:00
release.php move release.php to cli/release.php 2023-01-03 13:20:27 +01:00
rollup.config.js Everything to ES2020 2024-04-02 22:24:53 +02:00
SECURITY.md Update SECURITY.md 2024-09-16 17:07:53 +02:00
template.env Add better Docker development and prod support 2020-11-26 15:14:51 +01:00
yarn.lock Removed abandoned vulnerable rollup-plugin-html 2024-07-08 01:08:40 +02:00

README.md


SnappyMail


github-actions docker-image-size

Simple, modern, lightweight & fast web-based email client.

The drastically upgraded & secured fork of RainLoop Webmail Community edition.

We thank the RainLoop Team for making a great PHP 5 product that was good in the past.

Up to date system requirements, snappy performance, simple installation and upgrade, no database required - all these make SnappyMail a good choice.


For more information about the product, check snappymail.eu.

Information about installing the product, check the wiki page.

And don't forget to read the whole Wiki.

License

SnappyMail is released under GNU AFFERO GENERAL PUBLIC LICENSE Version 3 (AGPL). http://www.gnu.org/licenses/agpl-3.0.html

Copyright (c) 2020 - 2024 SnappyMail Copyright (c) 2013 - 2022 RainLoop

Modifications

This fork of RainLoop has the following changes:

  • Privacy/GDPR friendly (no: Social, Gravatar, Facebook, Google, Twitter, DropBox, X-Mailer)
  • Admin uses password_hash/password_verify
  • Auth failed attempts written to syslog
  • Added Fail2ban instructions
  • ES2020
  • PHP 7.4+ required
  • PHP mbstring extension required
  • PHP replaced pclZip with PharData and ZipArchive
  • Dark mode
  • Added option to remove background/font colors from messages for real "dark mode"
  • Removed BackwardCapability (class \RainLoop\Account)
  • Removed ChangePassword (re-implemented as plugin)
  • Removed POP3 support
  • Removed background video support
  • Removed Sentry (Application Monitoring and Error Tracking Software)
  • Removed Spyc yaml
  • Removed OwnCloud
  • Replaced gulp-uglify with gulp-terser
  • CRLF => LF line endings
  • Embed boot.js and boot.css into index.html
  • Removal of old JavaScript code (things are native these days)
  • Added modified Squire HTML editor as replacement for CKEditor
  • Updated Sabre/VObject
  • Split Admin specific JavaScript code from User code
  • Split Sieve specific JavaScript code from User code
  • JSON reviver
  • Better memory garbage collection management
  • Added serviceworker for Notifications
  • Added advanced Sieve scripts editor
  • Slimmed down language files
  • Replaced webpack with rollup
  • No user-agent detection (use device width)
  • Added support to load plugins as .phar
  • Replaced old Sabre library
  • AddressBook Contacts support MySQL/MariaDB utf8mb4
  • Added Fetch Metadata Request Headers checks
  • Reduced excessive DOM size
  • Support Kolab groupware
  • Support many more IMAP RFC's
  • Support Sodium and OpenSSL for encryption
  • Much better PGP support

Supported browsers

This fork uses downsized/simplified versions of scripts and has no support for Internet Explorer nor Edge Legacy. Supported are:

  • Chrome 80+
  • Edge 80+
  • Firefox 78+
  • Opera 67+
  • Safari 13.1+

Removal of old JavaScript

The result is faster and smaller download code (good for mobile networks).

  • Added dev/prototype.js for some additional features
  • Modified Jua.js to be without jQuery
  • Replaced Autolinker with simple https/email detection
  • Replaced momentToNode with proper HTML5 <time>
  • Replaced resize listeners with ResizeObserver
  • Replaced bootstrap.js with native drop-in replacement
  • Replaced dev/Common/ClientStorageDriver/* with Web Storage Objects polyfill
  • Replaced *Ajax with *Fetch classes because we use the Fetch API, not jQuery.ajax
  • Replaced knockoutjs 3.4 with a modified 3.5.1
  • Replaced knockout-sortable with native HTML5 drag&drop
  • Replaced simplestatemanager with CSS @media
  • Replaced inputosaurus with own code
  • Replaced keymaster with own shortcuts handler
  • Replaced OpenPGP.js v2 with OpenPGP.js v5
  • Removed ifvisible.js
  • Removed pikaday
  • Removed underscore
  • Removed polyfills
  • Removed Modernizr
  • Removed nanoscroll
  • Removed lightgallery
  • Removed jQuery
  • Removed jquery-ui
  • Removed jquery-scrollstop
  • Removed jquery-mousewheel
  • Removed matchmedia-polyfill
  • Removed momentjs (use Intl)
  • Removed opentip (use CSS)
  • Removed non-community (aka Prem/Premium/License) code
  • Removed ProgressJS

RainLoop 1.17 vs SnappyMail

js/* RainLoop Snappy
admin.js 2.170.153 84.925
app.js 4.207.787 447.263
boot.js 868.735 4.343
libs.js 658.812 233.728
sieve.js 0 91.418
polyfills.js 334.608 0
serviceworker.js 0 285
TOTAL 8.240.095 861.962
js/min/* RainLoop Snappy RL gzip SM gzip RL brotli SM brotli
admin.min.js 256.831 41.719 73.606 14.022 60.877 12.567
app.min.js 515.367 202.101 139.456 68.505 110.485 58.481
boot.min.js 84.659 2.231 26.998 1.271 23.643 1.067
libs.min.js 584.772 110.646 180.901 39.518 155.182 35.207
sieve.min.js 0 45.504 0 11.131 0 9.917
polyfills.min.js 32.837 0 11.406 0 10.175 0
TOTAL user 1.217.635 314.978 358.761 109.294 299.485 94.755
TOTAL user+sieve 1.217.635 360.482 358.761 120.425 299.485 104.672
TOTAL admin 959.099 154.596 292.911 54.811 249.877 48.841

For a user it is around 66% smaller and faster than traditional RainLoop.

CSS changes

  • Solve jQuery removed "features" with native css code
  • Themes work in mobile mode
  • Bugfix invalid/conflicting css rules
  • Use flexbox
  • Use border-box
  • Split app.css to have separate admin.css
  • Remove oldschool 'float'
  • Remove unused css
  • Removed html.no-css
  • Removed dev/Styles/Cmd.less
  • Removed dev/Styles/Scroll.less
  • Removed Internet Explorer from normalize.css
  • Removed node_modules/opentip/css/opentip.css
  • Removed node_modules/pikaday/css/pikaday.css
  • Removed unused vendors/bootstrap/less/*
  • Removed vendors/jquery-nanoscroller/nanoscroller.css
  • Removed vendors/jquery-letterfx/jquery-letterfx.min.css
  • Removed vendors/Progress.js/minified/progressjs.min.css
  • Removed gulp-autoprefixer
css/* RainLoop Snappy RL gzip SM gzip SM brotli
app.css 340.331 85.073 46.946 17.792 15.210
app.min.css 274.947 68.272 39.647 15.615 13.636
boot.css 1.326 664 545
boot.min.css 1.071 590 474
admin.css 30.880 7.045 6.127
admin.min.css 24.959 6.368 5.615

PGP

RainLoop uses the old OpenPGP.js v2 SnappyMail v2.12 uses OpenPGP.js v5, GnuPG and Mailvelope. SnappyMail is able to use and generate ECDSA and EDDSA keys, where RainLoop does not.

Since SnappyMail tries to achieve the best mobile experience, it forked OpenPGP.js to strip it down.

OpenPGP RainLoop Snappy RL gzip SM gzip RL brotli SM brotli
openpgp.min.js 330.742 546.165 102.388 169.207 84.241 138.688
openpgp.worker 1.499 824 695

Squire vs CKEditor

The Squire implementation is not 100% compatible yet, but it shows the massive overhead of CKEditor.

Still TODO:

  • support for tables (really needed?!?)
normal min gzip min gzip
squire 122.321 41.906 31.867 14.330
ckeditor ? 520.035 ? 155.916

CKEditor including the 7 asset requests (css,language,plugins,icons) is 633.46 KB / 180.47 KB (gzip).