Added some documentation

This commit is contained in:
the-djmaze 2022-02-25 12:11:32 +01:00
parent 47a6af52ba
commit 169dbfecca
2 changed files with 8 additions and 15 deletions

View file

@ -29,8 +29,8 @@ class AbstractView {
/* /*
onBuild() {} onBuild() {}
onBeforeShow() {} onBeforeShow() {} // Happens before: hidden = false
onShow() {} onShow() {} // Happens after: hidden = false
onHide() {} onHide() {}
*/ */
@ -71,13 +71,17 @@ export class AbstractViewPopup extends AbstractView
shortcuts.add('backspace', '', name, inFocus()); shortcuts.add('backspace', '', name, inFocus());
} }
// Happens when user hits Escape key
onClose() { onClose() {
return true; return true;
} }
/* /*
afterShow() {} onBeforeShow() {} // Happens before showModal()
afterHide() {} onShow() {} // Happens after showModal()
afterShow() {} // Happens after showModal() animation transitionend
onHide() {} // Happens before animation transitionend
afterHide() {} // Happens after animation transitionend
closeCommand() {} closeCommand() {}
*/ */

View file

@ -103,17 +103,6 @@ const
vmDom.classList.remove('animate'); // trigger the transitions vmDom.classList.remove('animate'); // trigger the transitions
} }
arePopupsVisible(0 < visiblePopups.size); arePopupsVisible(0 < visiblePopups.size);
/*
// the old ko.bindingHandlers.modal
const close = vmDom.querySelector('.close'),
click = () => vm.modalVisibility(false);
if (close) {
close.addEventListener('click.koModal', click);
ko.utils.domNodeDisposal.addDisposeCallback(vmDom, () =>
close.removeEventListener('click.koModal', click)
);
}
*/
}); });
vmDom.addEventListener('transitionend', endShowHide); vmDom.addEventListener('transitionend', endShowHide);
} }