KnockoutJS drop unused bindingRewriteValidators

This commit is contained in:
the-djmaze 2024-03-03 16:48:42 +01:00
parent 0f0f60e456
commit df8f13e359
4 changed files with 0 additions and 16 deletions

View file

@ -25,5 +25,4 @@ ko.bindingHandlers['foreach'] = {
'update': (element, valueAccessor, allBindings, viewModel, bindingContext) =>
ko.bindingHandlers['template']['update'](element, ko.bindingHandlers['foreach'].makeTemplateValueAccessor(valueAccessor), allBindings, viewModel, bindingContext)
};
ko.expressionRewriting.bindingRewriteValidators['foreach'] = false; // Can't rewrite control flow bindings
ko.virtualElements.allowedBindings['foreach'] = true;

View file

@ -53,7 +53,6 @@ function makeWithIfBinding(bindingKey, isWith, isNot) {
return { 'controlsDescendantBindings': true };
}
};
ko.expressionRewriting.bindingRewriteValidators[bindingKey] = false; // Can't rewrite control flow bindings
ko.virtualElements.allowedBindings[bindingKey] = true;
}

View file

@ -148,8 +148,6 @@ ko.expressionRewriting = (() => {
};
return {
bindingRewriteValidators: [],
// twoWayBindings: twoWayBindings,
parseObjectLiteral: parseObjectLiteral,

View file

@ -259,17 +259,5 @@
}
};
// Anonymous templates can't be rewritten. Give a nice error message if you try to do it.
ko.expressionRewriting.bindingRewriteValidators['template'] = bindingValue => {
var parsedBindingValue = ko.expressionRewriting.parseObjectLiteral(bindingValue);
if ((parsedBindingValue.length == 1) && parsedBindingValue[0]['unknown'])
return null; // It looks like a string literal, not an object literal, so treat it as a named template (which is allowed for rewriting)
if (ko.expressionRewriting.keyValueArrayContainsKey(parsedBindingValue, "name"))
return null; // Named templates can be rewritten, so return "no error"
return "This template engine does not support anonymous templates nested within its templates";
};
ko.virtualElements.allowedBindings['template'] = true;
})();